Version comparisons in Python Munki vs Swift Munki

[Gregory Neagle]

For context if what I’m writing about here, see: https://github.com/munki/munki/issues/1344

As it turns out, for this particular case, the Python version of Munki compares the two values differently than does the Swift version of Munki. Specifically:

In the Python version of Munki:

"8.0 (build 6300)” compares as higher than "8.0.1 (build 6301)”

In the Swift version of Munki:

"8.0 (build 6300)” compares as lower than "8.0.1 (build 6301)”

There are multiple issues here:

1) Neither version is a well-formed valid version string (which defined as a series of integers separated by periods), and so the result of a comparison where one or more string is not actually a valid version string is undefined.

2) The Swift result is actually what a human would likely consider “correct”.

3) The fact that Munki 7 compares these strings differently than prior versions of Munki is arguably a bug/issue/undesired behavior.

So: 

A) Should I leave it alone (with maybe a note somewhere that comparisons of non-well-formed version strings may differ), or 

B) Should I modify the implementation of MunkiVersion in the Swift code to match Python’s behavior here?

I’m leaning towards leaving it alone, but welcome other thoughtful opinions.

-Greg

[Allister Banks]

Revising the swift code so it resumes evaluation in a way that a computer thinks is right vs what a human understands as ‘wrong’ seems undesirable. As long as the swift behavior is expected and consistent I see no downside in leaving it as-is.
Allister

[Alan]

I'm also in favor of leaving it as is. Perhaps we could make a note about it in the Munki wiki, in case someone sees the discrepancy and asks about it?

On Wed, Apr 1, 2026 at 6:35 PM Allister Banks <a...@aru-b.com> wrote:

Revising the swift code so it resumes evaluation in a way that a computer thinks is right vs what a human understands as ‘wrong’ seems undesirable. As long as the swift behavior is expected and consistent I see no downside in leaving it as-is.
Allister

--
Find related discussion groups here:
https://github.com/munki/munki/wiki/Discussion-Group
---
You received this message because you are subscribed to the Google Groups "munki-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to munki-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/munki-dev/B3F38CA8-FE3B-49E6-9E20-73A5412FA240%40aru-b.com.

[Nick McSpadden]

Fourthed on leaving it as-is. Nonstandard/"non-traditional" version comparison should be stated as a potentially undefined behavior somewhere in the wiki and the admin should be prepared to consider alternatives.

To view this discussion visit https://groups.google.com/d/msgid/munki-dev/CAE%2BBptx8VX3wA1i-BWyfvwxbPkgS7%3DJ_4Zanm%2BYheYnatmeVKA%40mail.gmail.com.

--

--
Nick McSpadden
nmcsp...@gmail.com

[Vaughn Miller]

Another vote for leaving as is.   I tend to treat it as lucky happenstance when version strings like this actually work as a human would expect.

It is good to know that the swift an python comparisons differ.

Vaughn

To view this discussion visit https://groups.google.com/d/msgid/munki-dev/CAJySx-mGO6Ct5s1b6Sbmy8X-6Moio%3DCragNf29bDx7MO2_yV2Q%40mail.gmail.com.

[Elliot Jordan]

Agreed — A: leave as is.

Elliot

To view this discussion visit https://groups.google.com/d/msgid/munki-dev/CADWbj5nkXjAMn%2BxY_8niNHLEySQJiAgus_-j%2Bbu9avTj10LK1w%40mail.gmail.com.

[Gregory Neagle]

Leaving as-is. New documentation: https://github.com/munki/munki/wiki/Version-comparisons

-Greg

To view this discussion visit https://groups.google.com/d/msgid/munki-dev/CADefdwg%3Dk9L7yHGqK3H0eE_7ZmnGS3OMZcdwhY7dj1qq7PVq-A%40mail.gmail.com.