Changes affecting middleware and repo plugins.

137 views
Skip to first unread message

Gregory Neagle

unread,
Feb 20, 2024, 2:06:53 PMFeb 20
to munki-dev, 'Gregory Neagle' via munki-discuss
Munki makes use of Python’s “imp” module to import middleware and repo plugin files, if present. “imp” has been deprecated for a while in Python 3, and is not included in Python 3.12 (the current version of Python).

If Munki’s Python is ever to be updated past 3.10.x, a number of changes must be made, and replacing the use of the “imp” module is one of those changes.

As of this commit https://github.com/munki/munki/commit/1850dbe0773c90dafd9d8c32a35660c85bb5a34d in the Munki6dev branch, the use of “imp” has been replaced with “importlib.util”. It’s not a trivial replacement — the replacement code is more complex.

If you use middleware or repo plugins (I know SimpleMDM admins probably do), please test these changes.

-Greg


Daniel Moore

unread,
Feb 22, 2024, 11:40:26 AMFeb 22
to munki-dev
https://github.com/AaronBurchfield/CloudFront-Middleware works fine with the changes you made.

--
You received this message because you are subscribed to the Google Groups "munki-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to munki-discus...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/munki-discuss/7FE92E20-4D38-450B-85F1-6DA829495629%40mac.com.

greg.neagle

unread,
Feb 22, 2024, 4:08:31 PMFeb 22
to munki-dev
Thank you. If it works with one, I feel pretty confident if works with all.

-Greg

Rick Heil

unread,
Feb 27, 2024, 12:01:56 PMFeb 27
to munk...@googlegroups.com
Also works fine for Wade's S3 middleware (https://github.com/waderobson/s3-auth).

Thanks,
Rick

--
Find related discussion groups here:
https://github.com/munki/munki/wiki/Discussion-Group
---
You received this message because you are subscribed to the Google Groups "munki-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to munki-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/munki-dev/d1852736-def6-4b87-aa73-693d4d7a1728n%40googlegroups.com.


--

Rick Heil

Manager II, Security Engineering

rick...@samsara.com


samsara.com

Adam M. Anklewicz

unread,
Feb 28, 2024, 9:57:25 AMFeb 28
to munk...@googlegroups.com
Can also confirm that it works with Wade's S3 middleware.


--
Adam Anklewicz
Pronouns: he/him/his


Reply all
Reply to author
Forward
0 new messages