test-action dependencies

0 views
Skip to first unread message

Tobias Rautenkranz

unread,
Mar 25, 2009, 7:02:50 AM3/25/09
to mudb...@googlegroups.com
Running mb:test tests also dependent systems.

I think it should not. It also breaks when :trivial-features is a dependency,
since its files in the tests directory are loaded, but they are not intended to
be used like this.

Maybe (if you agree that dependencies should not be tested)

(defmethod dependency-applicablep ((dependency dependency)
(action test-action))
nil)
could be added to test-action.lisp


There are some files, that should be removed from the trivial-features package:
$ file trivial-features/0.4/tests/.*
[...]
trivial-features/0.4/tests/._package.lisp: AppleDouble encoded Macintosh file
trivial-features/0.4/tests/._sysinfo.lisp: AppleDouble encoded Macintosh file
trivial-features/0.4/tests/._tests.lisp: AppleDouble encoded Macintosh file
trivial-features/0.4/tests/._utsname.lisp: AppleDouble encoded Macintosh file

Tobias

signature.asc

Sean Ross

unread,
Mar 25, 2009, 7:50:27 AM3/25/09
to mudb...@googlegroups.com

On 25 Mar 2009, at 11:02, Tobias Rautenkranz wrote:

> Running mb:test tests also dependent systems.
>

Well, that's not right.

> I think it should not. It also breaks when :trivial-features is a
> dependency,
> since its files in the tests directory are loaded, but they are not
> intended to
> be used like this.
>
> Maybe (if you agree that dependencies should not be tested)
>
> (defmethod dependency-applicablep ((dependency dependency)
> (action test-action))
> nil)
> could be added to test-action.lisp
>


It most definitely should, I'll push out a new version of test-action
sometime today.


>
> There are some files, that should be removed from the trivial-
> features package:
> $ file trivial-features/0.4/tests/.*
> [...]
> trivial-features/0.4/tests/._package.lisp: AppleDouble encoded
> Macintosh file
> trivial-features/0.4/tests/._sysinfo.lisp: AppleDouble encoded
> Macintosh file
> trivial-features/0.4/tests/._tests.lisp: AppleDouble encoded
> Macintosh file
> trivial-features/0.4/tests/._utsname.lisp: AppleDouble encoded
> Macintosh file


Ouch, I seem to have been bitten once again by these hidden files.
This should be less of a problem going forward as I'm moving closer
and closer
to automatic releases from system definitions (this one was done using
tar).


Thanks for the report.

sean.

Reply all
Reply to author
Forward
0 new messages