Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Add reallocarray(3) and strtonum(3) to lib/libc/include/namespace.h

2 views
Skip to first unread message

Kamil Rytarowski

unread,
Jul 11, 2015, 9:38:14 AM7/11/15
to
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I would like to add the OpenBSD functions to lib/libc/include/namespace.
h.

The reasoning is that it seems correct as other libc functions are
there as well.

Any comments?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVoRnuAAoJEEuzCOmwLnZsIf4QAIWgg5zTRWGV3NC/qxIzaHwM
HYIULM8dPkjqAHy+Forfmr07D706dxuVo0f96jaOXa6nvxhTkjDMXDvE+x5IjSG6
5B5d2edPi4QfCoeScENuN3O1ZvPjgDPLt8FhIGn5Klk6NxYXjvwLH8W+syNEZ3CK
9UPn9mMghg4bcwQfgKgNurnd2CRHbHSdUe1m+PPd+P4PB06E3mmb2bPO+ZweYw4g
18+UpRxtPkmWLpzJQVB8x+MmBArEHqrEpLdLh0G8GJwLwaE/cS9uACK17Als2/ot
acYstWvNI+0a8Xq1jAbNTln5zQtxrUlWnDGBFd/unIOmK96gvPf7NkJraHnYfe/O
CrBXp1YgK4fZucK7ld5dDa8P/Lu1pYmBgniVT04JrlRxANErP7hTaJLeA5D/hl5E
H85tYROuvtf9RjZrQ05GS5QlNJ12xiMfc1tH9uF6BalkCPwN2+0E6VicSoZpAkkD
95J385HdfKSlSfGb4KfO0wJQfng1qWjd2Tum1/cJMThaXxOMYuFCJ8b/MeoKrJcl
jf8YnTdrp9DNeWqLkDHMETy3G0UMFetUMcvmA4WSX3t47t7RQqmMFZyuIGTRVRUV
DEaQ6ey1wN//e8Jaa6RDQ1KW6v8+k4YLUGtOZBb3ZtD/BccjrQrv6P3b4yfMzJDI
j0A19RtroziTvVeojQD9
=Z8Fw
-----END PGP SIGNATURE-----

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-...@muc.de

Taylor R Campbell

unread,
Jul 11, 2015, 10:34:09 AM7/11/15
to
Date: Sat, 11 Jul 2015 15:28:18 +0200
From: Kamil Rytarowski <n...@gmx.com>

I would like to add the OpenBSD functions to lib/libc/include/namespace.h.

The reasoning is that it seems correct as other libc functions are
there as well.

Any comments?

Sounds good -- but you will need to make some other changes too so
that the non-underscored symbol is exposed to applications. The
documentation on what that's all about is at src/lib/libc/README.
These are cases of nonstandard extensions.

Christos Zoulas

unread,
Jul 11, 2015, 5:48:54 PM7/11/15
to
In article <55A119F2...@gmx.com>, Kamil Rytarowski <n...@gmx.com> wrote:
>
>I would like to add the OpenBSD functions to lib/libc/include/namespace.
>h.
>
>The reasoning is that it seems correct as other libc functions are
>there as well.

They are not used internally by libc so this is not needed...

christos

Kamil Rytarowski

unread,
Jul 25, 2015, 10:41:01 PM7/25/15
to
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 11.07.2015 23:48, Christos Zoulas wrote:
> In article <55A119F2...@gmx.com>, Kamil Rytarowski
> <n...@gmx.com> wrote:
>>
>> I would like to add the OpenBSD functions to
>> lib/libc/include/namespace. h.
>>
>> The reasoning is that it seems correct as other libc functions
>> are there as well.
>
> They are not used internally by libc so this is not needed...
>

They are used externally.

Our base utilities and external utilities of our users depend on it. I
want to be prepared for possible drop of these functions in case of
obsoleting it upstream (in OpenBSD) or adaption for change of its
signature.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVtEeFAAoJEEuzCOmwLnZsxCYP/R0kx4MQxz/9Uzqu8ik2vLrD
2qUrCnKrJ4Df80r6JsnjxOCiG0zJ7h5hS6BOWtG7GBT3cShyL4pfR8Vu0QhsObg5
NcbfGd0yp+C3dScRlGAYHZP0/2/XqU0HBr0R7N+zEzJX0GxSUw+AKDYvWqBSGbVu
PxzJs/BECiIU27Tz1Wsp6FUzKBHwcNjEkXlmuxr1Zli1gkhCBfHaGgwl+LZn6Qcm
UAabiH18xWgdQYrLQNxpD7PredMos6I65SENeuFosUVxh/jaLSEpQJsflsS36pk1
FccyyKrS84MhkRhFzcHMwL/NCUUQgx6UrPId0C/Tb1d48ynvBPGGeecTzD1SOer5
SoBfSRM/mqb/ZXD5x8rpBPNNuUKr8ETZJcjHjrFbT/kgxNd+u+K1Xo2+3flRvYGp
CdbOQ97q2MMUNCYiCwnaSS5w7azhUbiM5CvjckEScIk1mcnpPUEei+Yd6fOaJL+Z
kuEGkmT0y+A96zJGuKmw+a3WRsYjgMWMqJDWRoJFryBubhEbdu+zkHXvpTZ0l+x2
YlPS9dQ7LlCnWB9ROj10jrscGpVFkmturInUgcSvWUTnbo2CJg9pVgCrUKzYbv1B
Wu+dMiqzPmrUnnWCLwpjbc/+yYDMl2LMjP6A5uIFkvKbtutMiJgeERiYixJctyBL
QJnvEhlQigjCzjwMxryU
=/X34

Martin Husemann

unread,
Jul 26, 2015, 4:23:16 AM7/26/15
to
On Sun, Jul 26, 2015 at 04:35:50AM +0200, Kamil Rytarowski wrote:
> Our base utilities and external utilities of our users depend on it. I
> want to be prepared for possible drop of these functions in case of
> obsoleting it upstream (in OpenBSD) or adaption for change of its
> signature.

This does not make any sense in the NetBSD context.
We do not break binary compatibility.

Martin

David Holland

unread,
Jul 26, 2015, 1:01:03 PM7/26/15
to
On Sun, Jul 26, 2015 at 04:35:50AM +0200, Kamil Rytarowski wrote:
> >> I would like to add the OpenBSD functions to
> >> lib/libc/include/namespace. h.
> >>
> >> The reasoning is that it seems correct as other libc functions
> >> are there as well.
> >
> > They are not used internally by libc so this is not needed...
>
> They are used externally.

The purpose of namespace.h (which is internal to libc) is so that
calls from libc to things that are supposed to be libc functions, but
are nonstandard, aren't disrupted when programs provide their own
symbols with the same names. If there aren't internal uses in libc,
namespace.h has no effect.

> Our base utilities and external utilities of our users depend on it. I
> want to be prepared for possible drop of these functions in case of
> obsoleting it upstream (in OpenBSD) or adaption for change of its
> signature.

namespace.h would not help in this event; this would require bumping
the major version of libc.so, which as you may have gathered is a
"nearly never" event.

now that the functions are in libc, they're in libc for keeps...

--
David A. Holland
dhol...@netbsd.org

Kamil Rytarowski

unread,
Jul 26, 2015, 1:16:35 PM7/26/15
to
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 26.07.2015 19:00, David Holland wrote:
> On Sun, Jul 26, 2015 at 04:35:50AM +0200, Kamil Rytarowski wrote:
>>>> I would like to add the OpenBSD functions to
>>>> lib/libc/include/namespace. h.
>>>>
>>>> The reasoning is that it seems correct as other libc
>>>> functions are there as well.
>>>
>>> They are not used internally by libc so this is not needed...
>>
>> They are used externally.
>
> The purpose of namespace.h (which is internal to libc) is so that
> calls from libc to things that are supposed to be libc functions,
> but are nonstandard, aren't disrupted when programs provide their
> own symbols with the same names. If there aren't internal uses in
> libc, namespace.h has no effect.
>
>> Our base utilities and external utilities of our users depend on
>> it. I want to be prepared for possible drop of these functions in
>> case of obsoleting it upstream (in OpenBSD) or adaption for
>> change of its signature.
>
> namespace.h would not help in this event; this would require
> bumping the major version of libc.so, which as you may have
> gathered is a "nearly never" event.
>
> now that the functions are in libc, they're in libc for keeps...
>

Thank you for making it clear.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVtRS/AAoJEEuzCOmwLnZsFs4P/1x6iFOPspKig+wxnP0VxI2X
rgP0/NdsUxbmKNsFRttDOnVnNmJ6fvN4MlcZKc/uibVIMAUS1upU1HIBhiRQI/ot
XU/QivuwnreR2Ivu4ynz1Hm7MR3XtXif/+rN6MJ1IMc8RS33EBpMStDu29ZVBkHy
u5jMcb/z+O1KOKQO3Wz/d16D91oYgn7LNx60Jo3evgEOX670VXItDFNS4KiW2hmk
gjGGTVostABl41Iy+8u6YDtMt97fSWqXgM5I/IC3hU2bj74nSZUTZ3PsdmRLzOkv
MjWjNQYvH10Afnguj9a4ja3yR2qh8rpO06DN5ta8m5dqZErXrRQzfpYMVanJq0Oq
RSJzmlDuAw/6t6Zpnsme1bq/Ip2yqvKAPKLJInOtNPWE1Jwk5ZIyy+s706fNQBAZ
fFZxFy7YP+QngOZHr7j3jHmjZlsjR12VKHsQSgl5Y0p6J1zfaLEn8szPcZPw1vnC
dwzxStXqBA50INKdqKcgqjCQ4fg/557GMCbx1yWVVka/KEKoQ7zXROpJSvItYm13
eQcCvOZuLlg56fc2YAfCejAdpRUrrHiqvU30ICDaGhG9y5HPIhki9JQp5TwbpFwJ
OqjNn+p2uaZGNg/9PqSvxGbLxh0/mY/43LJNHJ2SvUjCZ/dulywOFICjbB80Uwot
xYWMXQ9V8aJsSggp4rVc
=6IaC
0 new messages