Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

PR/48104 CVS commit: src/sys/net

1 view
Skip to first unread message

Ryota Ozaki

unread,
Jul 23, 2015, 6:55:10 AM7/23/15
to
The following reply was made to PR kern/48104; it has been noted by GNATS.

From: "Ryota Ozaki" <oza...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/48104 CVS commit: src/sys/net
Date: Thu, 23 Jul 2015 10:52:34 +0000

Module Name: src
Committed By: ozaki-r
Date: Thu Jul 23 10:52:34 UTC 2015

Modified Files:
src/sys/net: if_bridge.c

Log Message:
Fix PR 48104

So far bridge cannot receive frames via a member interface when the frames
come from another member interface. So when we assign an IP address to
a member interface, hosts connected to another member interface cannot
ping to the IP address. That behavior isn't expected. See PR 48104 for
more realistic examples of this issue.

The change does:
- drop M_PROMISC before ether_input, which allows a bridge member interface
to receive a frame coming from another bridge member interface
- receive broadcast/multicast frames via all bridge member interfaces,
which is required to receive IPv6 multicast packets destined to a
multicast group belonging to a bridge member interface that is different
from a packet arrival interface

roy@ helped testing of the fix, thanks!


To generate a diff of this commit:
cvs rdiff -u -r1.99 -r1.100 src/sys/net/if_bridge.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-...@muc.de

oza...@netbsd.org

unread,
Jul 23, 2015, 7:11:04 AM7/23/15
to
Synopsis: Incorrect forwarding of broadcast packets by bridge(4)

State-Changed-From-To: open->feedback
State-Changed-By: oza...@NetBSD.org
State-Changed-When: Thu, 23 Jul 2015 11:10:57 +0000
State-Changed-Why:
Fix committed to -current. Could you try -current?

Ryota Ozaki

unread,
Jul 23, 2015, 7:20:09 AM7/23/15
to
The following reply was made to PR kern/48104; it has been noted by GNATS.

From: "Ryota Ozaki" <oza...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/48104 CVS commit: src/tests/net/if_bridge
Date: Thu, 23 Jul 2015 11:05:34 +0000

Module Name: src
Committed By: ozaki-r
Date: Thu Jul 23 11:05:34 UTC 2015

Modified Files:
src/tests/net/if_bridge: t_bridge.sh

Log Message:
Reflect a fix for bridge

Due to PR 48104, some tests of ping/ping6 were failed but the tests now
should be successful. So reverse atf_check.

Bonus: the fix for PR 48104 also fixes another uknown failure.


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/tests/net/if_bridge/t_bridge.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


0 new messages