Re: www/rubygem-passenger creating slave ports

[Dan Langille]

> On Jan 12, 2018, at 11:48 AM, Dan Langille <d...@langille.org> wrote:
>
>
>> On Fri, Jan 12, 2018 at 7:23 AM, Dan Langille <d...@langille.org> wrote:
>>> On Jan 12, 2018, at 10:18 AM, Dan Langille <d...@langille.org> wrote:
>>>
>>> Sergey,
>>>
>>> We have a need to use rubygem-passenger with both Nginx and with Apache (on different servers).
>>>
>>> I propose to create two new slave ports:
>>>
>>> * www/rubygem-passenger-nginx
>>> * www/rubygem-passenger-passenger
>>
>> That should be:
>>
>>> * www/rubygem-passenger-apache
>>> * www/rubygem-passenger-nginx
>>
>> Sorry.
>>
>
>> On Jan 12, 2018, at 11:16 AM, Ultima <ultim...@gmail.com> wrote:
>>
>> This is an example of a perfect use case for flavors. Instead of
>> a slave port, creating an nginx flavor and apache flavor would
>> be a better approach.
>>
>
> Agreed.
>
> Flavors was our first choice, but is part of a much bigger project which will not arrive soon enough to meet this need.

https://reviews.freebsd.org/D13889

--
Dan Langille - BSDCan / PGCon
d...@langille.org



_______________________________________________
freebs...@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-port...@freebsd.org"

[Dan Langille]

Hello Sergey,

The proposed solution is a short term solution which goes away when FLAVORS are done for ruby. This is not soon.

We (feld@ & I) choose this solution as it has very little affect on the existing port.

The need arose today & we hope to proceed quickly with whatever can be done.

How do you suggest we proceed with the work?

Thank you

--
Dan Langille
http://langille.org/


> On Jan 12, 2018, at 7:33 PM, Sergey A. Osokin <o...@FreeBSD.org> wrote:
>
> Hi Dan,
>
> I don't see any reason to create two separate ports in this case and support
> them then cause potentially it's possible to modify the existing port to get
> the same result.
>
> --
> Sergey A. Osokin

>
>> On Fri, Jan 12, 2018 at 10:18:37AM -0500, Dan Langille wrote:
>> Sergey,
>>
>> We have a need to use rubygem-passenger with both Nginx and with Apache (on different servers).
>>
>> I propose to create two new slave ports:
>>
>> * www/rubygem-passenger-nginx
>> * www/rubygem-passenger-passenger
>>

>> To do this, I would like to make a one-line change to the master port:
>>
>>
>> Index: Makefile
>> ===================================================================
>> --- Makefile (revision 458852)
>> +++ Makefile (working copy)
>> @@ -24,7 +24,7 @@
>> APACHE22_DESC= Build with apache22 support
>> NGINX_DESC= Build with nginx support
>> SYMLINK_DESC= Create passenger symlink
>> -OPTIONS_DEFAULT= APACHE22
>> +OPTIONS_DEFAULT=? APACHE22
>>
>> USE_RUBY= yes
>> RAKE_BIN= ${LOCALBASE}/bin/rake
>>
>> This will allow the slave port to set OPTIONS_DEFAULT and build for the desired web server.
>>
>> If you agree, I am happen to make the commit / submit a patch for your approval.
>>
>> Thank you.