Hello! And a first attempt at a patch.

1 view
Skip to first unread message

Jesse Kinkead

unread,
Jul 12, 2013, 12:40:09 AM7/12/13
to mtg-fami...@googlegroups.com
Hi! I just started looking at the project this week - I've been using MTG familiar for a while, especially for price and card lookups. After poking around at the wishlist (doing some EDH planning), I felt like there was a pretty strong opportunity for some better list management tools in the app. And I'd found a bug I wanted to file. ;)

Anyway, now I've got it built, and I'm playing around with card list management ideas and improving some of the wishlist stuff.

I committed one starter change to my branch (https://code.google.com/p/mtg-familiar/source/detail?r=827), if anyone wants to take a look. I have no idea what I'm doing with respect to android icons, so any pointers would be appreciated. I just put some 32x32 images in the drawables/ directory and called it good . . .


Let me know if you have any comments - and how / if I should try to push stuff to the main branch!


- jesse

Jonathan Bettger

unread,
Jul 12, 2013, 2:04:35 AM7/12/13
to mtg-fami...@googlegroups.com
Welcome, nice to see somebody else from the better coast. (Also in the Emerald City.)

Like the change, I think most people would be happy to see it, along with being in the Trade fragment too (I started in the project just over a year ago there.) In regards to icons most tend to live in the drawable-mdpi-v4 folder, "@drawable/menu_plus" should get you our existing plus icon. [The whole dpi folders still confuse me a bit, there's just too damn many Android screen variants.]

Again, welcome.


--
You received this message because you are subscribed to the Google Groups "MTG Familiar Devs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mtg-familiar-d...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Adam Feinstein

unread,
Jul 12, 2013, 9:57:20 AM7/12/13
to mtg-fami...@googlegroups.com
On the subject of generic Android iconography, this is a good read: http://developer.android.com/design/style/iconography.html (not that we've adhered to it perfectly)

As for sorting out dpis and that ilk, you should bookmark this page: http://petrnohejl.github.io/Android-Cheatsheet-For-Graphic-Designers/

I like the sound of your changes, I'll check it out (literally) and give it a whirl later.
Reply all
Reply to author
Forward
0 new messages