[github] Comment created on issue 53 (update 7zsd module)

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

sschuberth added/edited comment:

@dscho In 9d6e6031e2d1c9c8908e2a161d68d6decb505304 you have replaced v4.65 with a [modified version of v4.49 beta](http://7zsfx.info/en/). What modifications that we need does this version offer over the vanilla 7zSD.sfx?

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

XhmikosR added/edited comment:

BTW, I'm talking about the same modified 7zsd. It's it's newer version works properly.

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

sschuberth added/edited comment:

Ah, was looking at the [History of changes](http://7zsfx.info/en/history.html), which only lists "1.2 RC1 (build 715) July 14, 2007" as the latest version. I did not realize until now that there is in fact [more recent version for download](http://7zsfx.info/en/download.html). I'll update to a recent version soon.

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

XhmikosR added/edited comment:

Yeah the English version of the site isn't really up to date...

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

sschuberth added/edited comment:

I've just updated the 7-Zip stuff on the "devel" branch.

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

XhmikosR added/edited comment:

Thanks. I will give it a go. BTW, I think 7zS.sfx, history-extra.txt and readme-extra.txt are not used. Maybe you should remove those and add just add a file to point to http://7zsfx.info/en/download.html for 7zSD.sfx.

Another minor thing, maybe you could change the method to LZMA2 for the portable release?

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

sschuberth added/edited comment:

We are using 7za.exe from the extra package, which is why I've added history-extra.txt and readme-extra.txt. I've removed the unused 7zS.sfx module, though.

Please submit a patch for LZMA2 support after testing that it works. I'm currently not in a position to test the built installers.

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

XhmikosR added/edited comment:

I tried LZMA2 for the portable release but I don't think it's worth moving to that.

19,7 MB (20.665.362 bytes) LZMA2
19,7 MB (20.659.416 bytes) LZMA2 64M
19,7 MB (20.661.180 bytes) LZMA 64M (current)

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

dscho added/edited comment:

Sorry for being really unavailable these days... I do not get to go online between office hours.

@sschuberth as to the version I committed: I do not recall making any modifications to it... ;-) Thanks for resolving this issue by doing all the work yourself!

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

sschuberth added/edited comment:

@XhmikosR Thanks for checking, so let's keep things as-is for now.

@dscho I was not talking about modification that *you* made to 7zSD.sfx, but I was wondering why you were using the modified version of 7zSD.sfx as opposed to the vanilla version at all. In your commit message you did not explain what feature in particular of the modified 7zSD.sfx we depend upon. Anyway, as the modified version of 7zSD.sfx is still maintained there is no need to fall back to the vanilla version and my question became irrelevant :-)

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

dscho added/edited comment:

@sschuberth oh, now I remember! I used some things in the configuration of the portable app that required a modified version... Let me see... Yep, it was the GUIMode and GUIFlags: https://github.com/msysgit/msysgit/blob/devel/share/WinGit/portable-release.sh#L40 (sorry I did not remember earlier...)

[GitHub]

See https://github.com/msysgit/msysgit/issues/53

sschuberth added/edited comment:

@dscho Ah, that's good to know for reference, thanks!