[github] Comment created on issue 18 (Fix git-svn)

[GitHub]

See https://github.com/msysgit/git/issues/18

aroben added/edited comment:

Note that either of these two commits would be sufficient to fix the bug on its own. But it seemed good to be thorough.

[GitHub]

See https://github.com/msysgit/git/issues/18

aroben added/edited comment:

I decided not to put the switch to `MakeMaker` in this PR, as it has some ripple effects.

[GitHub]

[GitHub]

See https://github.com/msysgit/git/issues/18

buildhive added/edited comment:

[MSysGit - the development behind Git for Windows » git #27](https://buildhive.cloudbees.com/job/msysgit/job/git/27/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

[GitHub]

See https://github.com/msysgit/git/issues/18

buildhive added/edited comment:

[MSysGit - the development behind Git for Windows » git #28](https://buildhive.cloudbees.com/job/msysgit/job/git/28/) SUCCESS

[GitHub]

See https://github.com/msysgit/git/issues/18

hvoigt added/edited comment:

Minor nit: In your commit message you say: "c102f4c and a618032 split some git-svn code into...". IMO it would be nicer to read: "Commit c102f4c and a618032 split some git-svn code into...". Could you also correct the linewrapping to fill up around 73 characters?

[GitHub]

See https://github.com/msysgit/git/issues/18

hvoigt added/edited comment:

Double posting again? Please don't do that! I can see the same change discussed on the upstream mailinglist:

http://thread.gmane.org/gmane.comp.version-control.git/200071

We are merging from there and will have to handle the merge conflicts. If you discuss it upstream please mention it in the pull request. Closing this so it will not accidentially be merged and the next person packaging a version annoyed by a conflict.

[GitHub]

See https://github.com/msysgit/git/issues/18

sschuberth added/edited comment:

@hvoigt Thanks for spotting the upstream discussion.

@aroben I would even go one step further: In general we are not interested in pull requests that duplicate upstream changes. That would simply generate unnecessary work. But thank you for the upstream fix, of course!

[GitHub]

See https://github.com/msysgit/git/issues/18

aroben added/edited comment:

I didn't know I would be sending the changes upstream when I made this pull request. I guess I should have closed it after doing so. Sorry for the trouble!