msgpack-rpc java - notifyMessage bug

14 views
Skip to first unread message

Young-Jin Seo

unread,
Sep 28, 2012, 11:12:00 PM9/28/12
to msgpa...@googlegroups.com
I tried to use notifyApply() in Java but failed.
I found a typo in src/main/java/org/msgpack/rpc/message/NotifyMessage.java.
This is a patch. Please review this.

Index: src/main/java/org/msgpack/rpc/message/NotifyMessage.java
===================================================================
--- src/main/java/org/msgpack/rpc/message/NotifyMessage.java (revision 474)
+++ src/main/java/org/msgpack/rpc/message/NotifyMessage.java (working copy)
@@ -45,11 +45,12 @@
         pk.writeArrayBegin(3);
         pk.write(Messages.NOTIFY);
         pk.write(method);
-        pk.write(args.length);
+        pk.writeArrayBegin(args.length);                          <======================  typo
         for (Object arg : args) {
             pk.write(arg);
         }
         pk.writeArrayEnd();
+        pk.writeArrayEnd();
     }
 
     public void readFrom(Unpacker u) throws IOException {
Index: src/main/java/org/msgpack/rpc/message/RequestMessage.java
===================================================================
--- src/main/java/org/msgpack/rpc/message/RequestMessage.java (revision 474)
+++ src/main/java/org/msgpack/rpc/message/RequestMessage.java (working copy)
@@ -57,6 +57,7 @@
             pk.write(arg);
         }
         pk.writeArrayEnd();
+        pk.writeArrayEnd();
     }
 
     public void readFrom(Unpacker u) throws IOException {

--
Seo Youngjin
Reply all
Reply to author
Forward
0 new messages