HTML fragment support for JavaScript code that executes document.write

[Ryan Petrich]

I've opened up an issue ticket on the mraid-web-tester project to add support for document.write inside HTML fragments, with a patch attached (see: https://code.google.com/p/mraid-web-tester/issues/detail?id=21). What are the next steps to getting a patch like this merged into the project? document.write support is important for our use of the tester as it is common for in-app tags to include document.write calls.

(mostly posting here for greater visibility, but if anyone on the group has suggestions, objections or revisions to the patch I would appreciate them)

[Nathan Carver]

Ryan,

Thanks for the contribution. I'll make sure this gets reviewed and included this week.

Thanks,

-Nathan

On Wed, Mar 19, 2014 at 11:11 PM, Ryan Petrich <ryan.p...@medialets.com> wrote:

I've opened up an issue ticket on the mraid-web-tester project to add support for document.write inside HTML fragments, with a patch attached (see: https://code.google.com/p/mraid-web-tester/issues/detail?id=21). What are the next steps to getting a patch like this merged into the project? document.write support is important for our use of the tester as it is common for in-app tags to include document.write calls.

(mostly posting here for greater visibility, but if anyone on the group has suggestions, objections or revisions to the patch I would appreciate them)

--
You received this message because you are subscribed to the Google Groups "MRAID Web Tester" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mraid-web-test...@googlegroups.com.
To post to this group, send email to mraid-we...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mraid-web-tester/9ba502ef-659b-4846-95e3-491ea7147c93%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Nathan Carver]

Ryan,

So I've updated the ticket as well, but we had some trouble taking the patch wholesale. We like the approach and it mostly works, but it also breaks one of the IAB certification ads that works before the patch. Are you able to review the ad attached to the ticket and see what changes are needed?

Thanks,

-Nathan