possible bug in fft/normmod_2expp1.c

16 views
Skip to first unread message

Wolfgang Gahr

unread,
Jul 20, 2019, 2:59:14 PM7/20/19
to mpir-devel
This is just a small file.
I think the line

if ((hi = t[limbs]))

should be written as

if ((hi == t[limbs]))

Hope this helps.

Bill Hart

unread,
Jul 20, 2019, 3:01:22 PM7/20/19
to mpir-devel
Are you sure? The double parentheses are usually used to remind oneself that a single = was intended and not a typo.

Do you have a failing case for the FFT, or some reasoning as to why the code is incorrect in its current state?

--
You received this message because you are subscribed to the Google Groups "mpir-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mpir-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mpir-devel/87a7d50d-499a-4163-9e72-3e9e2e36a97c%40googlegroups.com.

Wolfgang Gahr

unread,
Jul 20, 2019, 3:50:59 PM7/20/19
to mpir-devel
just my compiler mentioned it .. and it was only one in the whole sources.


Am Samstag, 20. Juli 2019 21:01:22 UTC+2 schrieb Bill Hart:
Are you sure? The double parentheses are usually used to remind oneself that a single = was intended and not a typo.

Do you have a failing case for the FFT, or some reasoning as to why the code is incorrect in its current state?

On Sat, 20 Jul 2019 at 20:59, Wolfgang Gahr <gahrwo...@gmail.com> wrote:
This is just a small file.
I think the line

        if ((hi = t[limbs]))

should be written as

        if ((hi == t[limbs]))

Hope this helps.

--
You received this message because you are subscribed to the Google Groups "mpir-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mpir-...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages