Drop Targets - Resetting after first completion

[Greg Sealby]

I am configuring some shot groups that include drop targets.  I've been noticing something unexpected in the logs and was wondering if this is because I am running it under non-hardware mode (-X) or if there is something wrong in my drop target config.

2019-04-26 12:52:47,045 : INFO : EventManager : Event: ======'s_drop_target_s_active'====== Args={}

2019-04-26 12:52:47,045 : INFO : EventManager : Event: ======'drop_target_s_down'====== Args={'device': <drop_target.s>}

2019-04-26 12:52:47,045 : INFO : EventManager : Event: ======'drop_target_bank_dtb_celts_mixed'====== Args={'down': 1}

2019-04-26 12:52:47,127 : INFO : EventManager : Event: ======'drop_target_s_up'====== Args={'device': <drop_target.s>}

2019-04-26 12:52:47,127 : INFO : EventManager : Event: ======'drop_target_bank_dtb_celts_up'====== Args={}

It looks like it is is popping up the drop target immediately, which means that it is never firing the drop_target_bank_dtb_celts_down event.  It was causing a problem the second time around as it was not "advancing" and never completing the bank shot.  I removed my reset_coils configuration from my drop_targets: configuration and added this line to my drop_target_banks: configuration:

        reset_events: drop_target_bank_dtb_celts_down, shot_dt_celts_complete

I am still getting the above events, which don't look right to me (maybe I am wrong).  Adding the shot complete event to the config works, but feels like a workaround as I have something configured incorrectly.

Any advice?

[jabdoa]

That looks weird. Smart virtual should only reset it when the coil is pulsed. Also it would toggle the switch which does not seem to happe here. Can you post your full drop_targets, drop_target_banks and the relevant shots?

Jan

[Greg Sealby]

Thanks Jan, appreciate your help again.

Drop Target config:

drop_targets:

    c:

        switch: s_drop_target_c

#        reset_coil: c_drop_target_reset

    e:

        switch: s_drop_target_e

#        reset_coil: c_drop_target_reset

    l:

        switch: s_drop_target_l

#        reset_coil: c_drop_target_reset

    t:

        switch: s_drop_target_t

#        reset_coil: c_drop_target_reset

    s:

        switch: s_drop_target_s

#        reset_coil: c_drop_target_reset

drop_target_banks:

    dtb_celts:

        drop_targets: c, e, l, t, s

        reset_coils: c_drop_target_reset

        reset_events: drop_target_bank_dtb_celts_down, shot_dt_celts_complete

        reset_on_complete: 1s

Shots configured in my mode:

shots:

# CLUB

    shot_hc_left_horseshoe_l1:

        hit_events: shot_left_horseshoe_hit

    shot_hc_right_horseshoe_l1:

        hit_events: shot_right_horseshoe_hit

    shot_hc_orbit_left_l1:

        hit_events: shot_orbit_left_hit

    shot_hc_orbit_right_l1:

        hit_events: shot_orbit_right_hit

    shot_hc_dt_celts_l1:

        hit_events: shot_dt_celts_complete

Shot group configured in my mode:

shot_groups:

# CLUB

    shot_highland_champion_club_1:

        shots: shot_hc_left_horseshoe_l1, shot_hc_orbit_left_l1, shot_hc_dt_celts_l1 

        enable_events: highland_champion_club_start

        disable_events: 

            - highland_champion_stop

            - highland_champion_county_start

            - highland_champion_national_start

            - highland_champion_world_start

        reset_events: highland_champion_club_start

    shot_highland_champion_club_2:

        shots: shot_hc_right_horseshoe_l1, shot_hc_orbit_right_l1, shot_hc_dt_celts_l1 

        enable_events: highland_champion_club_start

        disable_events: 

            - highland_champion_stop

            - highland_champion_county_start

            - highland_champion_national_start

            - highland_champion_world_start

        reset_events: highland_champion_club_start

    shot_highland_champion_club_3:

        shots: shot_hc_left_horseshoe_l1, shot_hc_orbit_right_l1, shot_hc_dt_celts_l1 

        enable_events: highland_champion_club_start

        disable_events: 

            - highland_champion_stop

            - highland_champion_county_start

            - highland_champion_national_start

            - highland_champion_world_start

        reset_events: highland_champion_club_start

    shot_highland_champion_club_4:

        shots: shot_hc_right_horseshoe_l1, shot_hc_orbit_left_l1, shot_hc_dt_celts_l1 

        enable_events: highland_champion_club_start

        disable_events: 

            - highland_champion_stop

            - highland_champion_county_start

            - highland_champion_national_start

            - highland_champion_world_start

        reset_events: highland_champion_club_start

Sequence shot configured in my base mode:

sequence_shots:

    shot_left_horseshoe:

        switch_sequence: s_rollover_horseshoe_left, s_rollover_horseshoe_right

        sequence_timeout: 1s

    shot_right_horseshoe:

        switch_sequence: s_rollover_horseshoe_right, s_rollover_horseshoe_left

        sequence_timeout: 1s

    shot_orbit_left:

        switch_sequence: s_rollover_top_left_orbit, s_rollover_top_right_orbit

        sequence_timeout: 2s

    shot_orbit_right:

        switch_sequence: s_rollover_top_right_orbit, s_rollover_top_left_orbit

        sequence_timeout: 2s

Event player from my mode:

# CLUB

    shot_hc_left_horseshoe_l1_hit: shot_hc_horseshoe_hit

    shot_hc_right_horseshoe_l1_hit: shot_hc_horseshoe_hit

    shot_hc_orbit_left_l1_hit: shot_hc_orbit_hit

    shot_hc_orbit_right_l1_hit: shot_hc_orbit_hit

    shot_hc_dt_celts_l1_hit: shot_hc_dt_hit

[jabdoa]

Hi Greg,

I was first confused by the log. Unfortunately, it does not show any switch change and we do not post events for switches when there is not handler (because of a performance optimisation). I guess you drop target bank was just reset for some reason. Not sure why. You config looks fine to me.

1. Are you reusing your reset coil somewhere? smart virtual will reset your targets when that coil is pulsed.

2. Can you post a log with verbose (-v -V) which shows all the switch changes?

3. If that does not help, can you try to build a minimal example (i.e. delete stuff until it works and only keep what it needed to reproduce the issue)?

Jan

[Greg Sealby]

Hi Jan,

Thanks for the ideas.  I did a search through my device config and could not see another coil using c_drop_target_reset anywhere.  So can rule out a) I think.

I've attached a couple of logs.  First one (2019-04-28-09-43-09) shows the behaviour without going into any modes and just hitting the keyboard keys representing each drop target.

For the second log, I added a toggle: true command to to the drop target switches in my keymap.yaml.  Is this the simple solution to this issue, or does that mean the switch is not behaving as it would normally?

Thanks,

Greg

[jabdoa]

If you so not put toggle on your keys the switches will only be activated as long as you press the key. So there is no problem at all?

Jan