Upgrade to .57

[Ben Tripoli]

Hi. I did a install mpf manually from this  https://missionpinball.org/latest/install/linux/ as I was on .56

I ended up with version 57.3 is this a development version? As I dont see it in the version list. I didnt use -pre which I think is the way to get dev. Did I do something wrong?

These are my exact steps

sudo pip3.8 uninstall mpf-mc mpf

python3.8 -m pip install --upgrade pip python3.8 -m 

pip install --upgrade setuptools python3.8 -m 

pip install --upgrade pillow

pip3.8 install mpf[all]

pip3.8 install mpf-mc pip3.8 

[Ben Tripoli]

So just further and why I was asking if 57.3 is a development version, I have made all the changes for the upgrade but Im getting the following error on most of my timers.

This is from attract mode. When I have this in my attract timer

      - event: s_right_flipper_active
        action: restart

I get this Error

jump() got multiple values for argument 'timer_value'

When I replaced it with Jump (see below) it works, but I'm somewhat confused on what has changed with timers.

 textscroll:

    start_value: 90
    end_value: 0
    direction: down
    tick_interval: 1.5s
    control_events:
      - event: s_select_weapon_active
        action: pause
        value: 5
  #    - event: s_right_flipper_active
  #      action: restart
      - event: s_right_flipper_active
        action: jump
        value: 90
    start_running: true
    restart_on_complete: true

[Anthony van Winkle]

Congratulations, you've found a bug!!

Turns out this bug has been a flaw in the Timer code for years, but never showed up because it requires a control_event with a value to be listed in the timer config before a restart event, which I guess nobody has ever done before. Nice work!

I've implemented a fix and opened a PR for it here: https://github.com/missionpinball/mpf/pull/1851

This, along with some other bug fixes and improvements, well be merged into the 0.57 branch today and a new release made. I'll post a follow-up here when that's available. Thanks!

[Anthony van Winkle]

You can now upgrade to 0.57.4.dev1 with the fixed timer code (and much more!) with the following command:

pip install --upgrade mpf==0.57.4.dev1

[Ben Tripoli]

So my dodgy code shows its face again, now in public! But it all seems fixed in 57.4, much appreciated Anthony.