Issue 167 in mp4v2: Integer overflow/wraparound in \src\mp4track.cpp

6 views
Skip to first unread message

mp...@googlecode.com

unread,
Mar 26, 2014, 4:33:24 PM3/26/14
to mp...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 167 by shankar...@gmail.com: Integer overflow/wraparound in
\src\mp4track.cpp
http://code.google.com/p/mp4v2/issues/detail?id=167

In line 1124: if (d <= sampleCount * sampleDelta), there is a change for an
integer wraparound here.

d is of type MP4Duration, which is unint64_t. The multiplication is of two
uint32_t.

A simple change would be to cast of the operands to MP4Duration which would
convert both of the operands to MP4Duration before multiplication.

I am using the latest version of mp4v2.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages