Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

New names for old things..

8 views
Skip to first unread message

Dustin Mitchell

unread,
May 24, 2019, 11:14:09 AM5/24/19
to tools-taskcluster
We're considering some changes to terminology in the Taskcluster platform
as we implement the worker-manager service to replace the AWS provisioner.

The first change is, we want to get rid of the "provisionerId" term, since
we don't have provisioner's to Id'entify anymore. The plan is to combine
the two into a single identifier.

The second change is to remove the ambiguity around what a "worker type" is
-- for the taskcluster-queue service, it's a queue of tasks; while for the
worker manager it's a pool of workers. It just happens that poll pulls
tasks from that queue.

So, in the queue we'll combine `<provisionerId>/<workerType>` into
`queueId`; in worker-manager we'll combine `<provisionerId>/<workerType>`
into `poolId`. Workers in pool <poolId> will pull tasks from queue
<queueId> where poolId = queueId. Kudos to pete for the queueId/poolId
names!

We have a nice path for compatibility here, too: if we're careful about
urlencoding, we can make the same endpoints work of both
`<provisionerId>/<workerType>` and `<queueId>` or `<poolId>`. For example:

/api/queue/v1/claim-work/someProv/someWT

could be either provisionerId=someProv / workerType=someWT, or
queueId=someProv/someWT. Similarly, in task definitions we can include all
three properties: `workerType`, `provisionerId`, and `queueId`. Eventually
we can deprecate use of the first two and stop returning them. Finally, we
can drop the requirement that there be a `/` in queueIds and poolIds.

I'm curious for your thoughts on this!

Dustin

Dustin Mitchell

unread,
May 24, 2019, 1:30:58 PM5/24/19
to Irene S, tools-taskcluster
I'm open to those names, too -- what do others think?

Dustin

On Fri, May 24, 2019 at 12:33 PM Irene S <bugze...@gmail.com> wrote:

> I welcome this change wholeheartedly! I also like the new names - they
> make sense. I would maybe clarify them even further: <queueId> ==>
> <tasksQueueId> (I feel there are so many various “queues” in Taskcluster
> universe) and <poolId> ==> <workerPoolId>, but it’s a matter of taste
> probably, and really a minor nit. Ship it! 🚢

Brian Stack

unread,
May 24, 2019, 1:32:18 PM5/24/19
to Dustin Mitchell, Irene S, tools-taskcluster
I like owlish's names a lot. +1
> _______________________________________________
> tools-taskcluster mailing list
> tools-ta...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/tools-taskcluster
>

Dustin Mitchell

unread,
Jun 6, 2019, 1:01:23 PM6/6/19
to Brian Stack, Irene S, tools-taskcluster
I filed an RFC for this today --

https://github.com/taskcluster/taskcluster-rfcs/pull/145

Please take a look. I welcome comments!

Dustin
0 new messages