Proposal for an Exceptions to Review

[Jake Watkins]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I would like to propose a new Exceptions to Review flag.

a=userdir - self-approval if you're changing your *own* user directory
files

I don't see a need for review on changing your own user directory
files. This could also encourage people to use it. :-)


- - Jake Watkins
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTaWomAAoJECUHH3v7Nbj1PyAH/29W+wkdnGdzqDJ4zv/wF2wG
fkn80Fk6+7wFsueJCJND0wwzmhBNBJKPz9Z4ek3HTBQY88CvYOYehz9YrWsTpVAY
VJUALjm6BuY1dg9qIirDl0KyZZFWeW6clz5ufLocul/Scm8PZZYY7apuTtu+CKGi
5i2PuHekYhrCgJEVJ+c0uK8qu7dHvDZs73HXJ6B+LbuCYftevqgoYhFui/idz+Wu
EVS1LSpsoul8Sa9dKhnJM9QsXS2H5QqUIXDRpYJ9UOLmIRGy3SoGzqxbmY+3Gg7C
qfidJP5xfl6WNPrwwS0E8N5kvv8J7/05Q/C+S9kWd3xedVptTkwezxcMbu8Dg38=
=GRnW
-----END PGP SIGNATURE-----

[Dustin J. Mitchell]

Assuming that's just under modules/users/files/people/$username, I don't see how that could cause any harm. Well, I can think of one way: adding a huge file that slows down puppet and takes up lots of space. Let's not do that.

So I'm happy with this if there are no other objections. It should go on
https://wiki.mozilla.org/ReleaseEngineering/PuppetAgain/HowTo/Hack_on_PuppetAgain#Exceptions_to_Review_Requirement

Please include text specifically excluding large files.

Dustin

> _______________________________________________
> tools-puppetagain mailing list
> tools-pu...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/tools-puppetagain
>

[Justin Wood]

Works for me,

Though to be clear, this could also elicit malice if used with templates and secrets in some way. (I don't expect anyone who *can* push this stuff would do so, but worth calling out as a thing-to-watch-for)

~Justin Wood (Callek)

[Dustin J. Mitchell]

----- Original Message -----
> Though to be clear, this could also elicit malice if used with templates and
> secrets in some way. (I don't expect anyone who *can* push this stuff would
> do so, but worth calling out as a thing-to-watch-for)

You can't put either of those things in a module's files/ directory.

Dustin