Peter Bengtsson
unread,Nov 10, 2011, 8:17:52 PM11/10/11You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to tools...@lists.mozilla.org, Jason Grlicky
* now grouped by application names. (the trick relies on the first 2
characters of the tree code name)
* removed "X,XXX strings"
* changed the order of the progress bar as per Axel's advice
* Fixed various bugs that made it not HTML validate
* Optimized the lookup of appversions to reduce excess SQL queries.
Ignore this Jason...
In terms of optimization, profiling seems to hint to this piece of code::
# get the suggested signoff
forest = run.tree.l10n
repo = get_object_or_404(Repository, locale=loc, forest=forest)
__, __, run.suggested_shortrev = annotated_pushes(repo,
run.appversion,
loc, actions)
That's costing us about 5 or 6 SQL queries per tree. Not a huge problem
at all but if you can think of a way to simplify that calculation I'd
love to give it a try.