Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

observation: extending the Context class

2 views
Skip to first unread message

darrel karisch

unread,
Sep 22, 2008, 2:28:34 PM9/22/08
to
it's a bit awkward following the ContextFactory example that includes
a reference to MyContext that presumably extends Context and then find
that the only public Context ctor is deprecated.

Hannes Wallnoefer

unread,
Sep 22, 2008, 5:54:45 PM9/22/08
to

You can - and should - call the protected constructor that takes a
ContextFactory argument. Java access modifiers can be really
confusing, which is why everybody loves JavaScript :-)

hannes

darrel karisch

unread,
Sep 23, 2008, 12:04:06 PM9/23/08
to
in release 1.7 that ctor has package scope, not protected.

Hannes Wallnoefer

unread,
Sep 23, 2008, 4:05:40 PM9/23/08
to
On Sep 23, 6:04 pm, darrel karisch <dkari...@gmail.com> wrote:
> in release 1.7 that ctor has package scope, not protected.

Sorry, I hadn't noticed. Good to see Attila has fixed this already.

hannes

Attila Szegedi

unread,
Sep 24, 2008, 6:55:18 PM9/24/08
to Hannes Wallnoefer, dev-tech-js-...@lists.mozilla.org
Yeah, somebody else pointed it out to me in private mail few weeks
ago. It's not in a released version yet, though.

Attila.

Attila Szegedi

unread,
Sep 25, 2008, 12:34:22 PM9/25/08
to darrel karisch, rhino Dev
(Replying to list too)

The thing is, unlike Context, I'm not too familiar with design
decisions of IdScriptableObject, so I wouldn't be comfortable doing
this change myself. I'm fairly certain it would be okay, but I'll need
to read through it first to properly convince myself of this.
Alternatively, another committer can also take a look into it.

Attila.

On Sep 25, 2008, at 4:09 PM, darrel karisch wrote:

> while I have your attention, can you change
> IdScriptableObject::newIdFunction from private to protected?
> http://groups.google.com/group/mozilla.dev.tech.js-engine.rhino/browse_thread/thread/0f9f1325088e47d3#
> TIA.

darrel karisch

unread,
Oct 2, 2008, 4:28:39 PM10/2/08
to
okay, how can we convince another committer (Norris ) to take a look?
http://groups.google.com/group/mozilla.dev.tech.js-engine.rhino/browse_thread/thread/0f9f1325088e47d3#

darrel karisch

unread,
Oct 3, 2008, 9:09:08 AM10/3/08
to
Attila,
granted, you may not be familiar with the code base. however, it is
immediately clear that it cannot have any impact on the current Rhino
objects that extend IdScriptableObject. it can only impact
IdScriptableObject extensions external to Rhino and then, only to
those developers who choose to avail themselves of the increased
openness. why would Rhino developers/committers object to what users
and extenders of Rhino do outside of their purview?
0 new messages