Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Is this a bug with the Parser API
18 views
Skip to first unread message
Masquerade
Feb 11, 2012, 5:30:43 AM2/11/12
to
A statement like this:
var a=[1,2,3,,,] // note the 3 trailing commas
should mean a sparse array containing 5 elements. First 3 are numbers,
2 trailing undefined elements and the last trailing comma is ignored
by the parser. But the Parser API only produce an AST containing an
array of 3 elements for the first 3 numbers i.e. it drops all the
trailing commas instead of just the last one.
Is it a bug?
var a=[1,2,3,,,] // note the 3 trailing commas
should mean a sparse array containing 5 elements. First 3 are numbers,
2 trailing undefined elements and the last trailing comma is ignored
by the parser. But the Parser API only produce an AST containing an
array of 3 elements for the first 3 numbers i.e. it drops all the
trailing commas instead of just the last one.
Is it a bug?
Jason Orendorff
Feb 11, 2012, 10:54:48 AM2/11/12
to Masquerade, dev-tech-js-en...@lists.mozilla.org
code review from Dave Herman since March of last year. :)
Let's get the fix in; would someone steal that review please?
-j
David Herman
Feb 12, 2012, 12:36:29 PM2/12/12
to Jason Orendorff, Masquerade, dev-tech-js-en...@lists.mozilla.org
On Feb 11, 2012, at 7:54 AM, Jason Orendorff wrote:
> On 2/11/12 4:30 AM, Masquerade wrote:
>>
>> Is it a bug?
>
> Yes, this is bug 630232, which has a patch and has been waiting on a code review from Dave Herman since March of last year. :)
My bad, somehow this escaped my notice. I'll review it this week.
> On 2/11/12 4:30 AM, Masquerade wrote:
>>
>> Is it a bug?
>
> Yes, this is bug 630232, which has a patch and has been waiting on a code review from Dave Herman since March of last year. :)
Dave
David Herman
Feb 15, 2012, 6:16:35 PM2/15/12
to Jason Orendorff, Masquerade, dev-tech-js-en...@lists.mozilla.org
r=me
Thanks,
Dave
On Feb 11, 2012, at 7:54 AM, Jason Orendorff wrote:
> On 2/11/12 4:30 AM, Masquerade wrote:
> dev-tech-js-engine-internals mailing list
> dev-tech-js-en...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
Thanks,
Dave
On Feb 11, 2012, at 7:54 AM, Jason Orendorff wrote:
> On 2/11/12 4:30 AM, Masquerade wrote:
> Yes, this is bug 630232, which has a patch and has been waiting on a code review from Dave Herman since March of last year. :)
>
>
> Let's get the fix in; would someone steal that review please?
>
> -j
> _______________________________________________
>
> -j
> dev-tech-js-engine-internals mailing list
> dev-tech-js-en...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
0 new messages