superreview requested: [Bug 1503422] Debugger doesn't see sources that are cleaned up by GC : [Attachment 9048707] Part 2 - Notify JS when navigating.

[Bugzilla@Mozilla]

Brian Hackett (:bhackett) <bhacke...@gmail.com> has asked Olli Pettay
[:smaug] <bu...@pettay.fi> for superreview:
Bug 1503422: Debugger doesn't see sources that are cleaned up by GC
https://bugzilla.mozilla.org/show_bug.cgi?id=1503422

Attachment 9048707: Part 2 - Notify JS when navigating.
https://bugzilla.mozilla.org/attachment.cgi?id=9048707&action=edit



--- Comment #13 from Brian Hackett (:bhackett) <bhacke...@gmail.com> ---
Created attachment 9048707
--> https://bugzilla.mozilla.org/attachment.cgi?id=9048707&action=edit
Part 2 - Notify JS when navigating.

This patch uses the API added in part 1 to notify the JS engine's debugger when
a page navigates (goes back/forward, reloads, or visits a new URI).


--

[Bugzilla@Mozilla]

Olli Pettay [:smaug] <bu...@pettay.fi> has reassigned Brian Hackett (:bhackett)
<bhacke...@gmail.com>'s request for superreview:

Bug 1503422: Debugger doesn't see sources that are cleaned up by GC
https://bugzilla.mozilla.org/show_bug.cgi?id=1503422

Attachment 9048707: Part 2 - Notify JS when navigating.
https://bugzilla.mozilla.org/attachment.cgi?id=9048707&action=edit

--- Comment #15 from Olli Pettay [:smaug] <bu...@pettay.fi> ---
Comment on attachment 9048707
--> https://bugzilla.mozilla.org/attachment.cgi?id=9048707

Part 2 - Notify JS when navigating.

Do we need to care about bfcached pages?
Somewhere around
https://searchfox.org/mozilla-central/rev/3e0f1d95fcf8832413457e3bec802113bdd1f
8e8/docshell/base/nsDocShell.cpp#7238

Do we need to deal with navigations in iframes somehow differently?
And...OnNavigate is static. So if a background tab navigates, we still notify.
Is that all expected?


--