Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview requested: [Bug 744360] B2G MMS: Support WAP over SMS : [Attachment 625198] Part 1: IDL changes

0 views
Skip to first unread message

bugzill...@mozilla.org

unread,
May 18, 2012, 3:35:37 PM5/18/12
to dev-supe...@lists.mozilla.org
Vicamo Yang [:vicamo] <vy...@mozilla.com> has asked Philipp von Weitershausen
[:philikon] <phi...@weitershausen.de> for superreview:
Bug 744360: B2G MMS: Support WAP over SMS
https://bugzilla.mozilla.org/show_bug.cgi?id=744360

Attachment 625198: Part 1: IDL changes
https://bugzilla.mozilla.org/attachment.cgi?id=625198&action=edit


------- Additional Comments from Vicamo Yang [:vicamo] <vy...@mozilla.com>
I'd like to replace WapBinaryInputStream with BinaryInputStream, but had
problem in seeking it. There seems no easy way to create a BIS, so I must
create an StorageStream first. However, StorageStream doesn't seem to support
nsISeekableStream(?) I mark this as feedback for now.

bugzill...@mozilla.org

unread,
May 23, 2012, 8:17:30 PM5/23/12
to dev-supe...@lists.mozilla.org
Philipp von Weitershausen [:philikon] <phi...@weitershausen.de> has canceled
Vicamo Yang [:vicamo] <vy...@mozilla.com>'s request for superreview:
Bug 744360: B2G MMS: Support WAP over SMS
https://bugzilla.mozilla.org/show_bug.cgi?id=744360

Attachment 625198: Part 1: IDL changes
https://bugzilla.mozilla.org/attachment.cgi?id=625198&action=edit


------- Additional Comments from Philipp von Weitershausen [:philikon]
<phi...@weitershausen.de>
Review of attachment 625198:
-----------------------------------------------------------------

I may have missed this in the previous patches, but I'm not quite sure why this
is needed. Why is a Uint8Array not sufficient?
0 new messages