superreview requested: [Bug 629500] Remove generic print dialogs and massively refactor that layer of the printing system : [Attachment 507633] 1/19: Remove the generic XUL-based print and page setup dialogs from toolkit/.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507633: 1/19: Remove the generic XUL-based print and page setup
dialogs from toolkit/.
https://bugzilla.mozilla.org/attachment.cgi?id=507633&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507634: 2/19: Remove all references to the old print dialogs from
all implementations of nsIPrintingPromptService, etc
https://bugzilla.mozilla.org/attachment.cgi?id=507634&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507635: 3/19: Remove two totally unused nsIPrintOptions methods.
https://bugzilla.mozilla.org/attachment.cgi?id=507635&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507636: 4/19: Remove nsIPrintSettingsService.defaultPrinterName.
https://bugzilla.mozilla.org/attachment.cgi?id=507636&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507638: 5/19: Move the backend-specific code behind
nsIPrintSettingsService::InitPrintSettingsFromPrinter from nsIPrinterEnumerator
to nsIDeviceContextSpec.
https://bugzilla.mozilla.org/attachment.cgi?id=507638&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507641: 7/19: Use GetDefaultPrinterW() on Windows instead of
nsIPrinterEnumerator (which used GetProfileString!); remove the
nsIPrinterEnumerator impl.
https://bugzilla.mozilla.org/attachment.cgi?id=507641&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507644: 8/19: Remove the remaining nsIPrinterEnumerator
implementations, which are now unused.
https://bugzilla.mozilla.org/attachment.cgi?id=507644&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507647: 10/19: Remove nsIContentViewerFile and all references to
nsIPrintOptions outside widget/.
https://bugzilla.mozilla.org/attachment.cgi?id=507647&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507648: 11/19: Fold nsIPrintOptions into nsIPrintSettingsService.
https://bugzilla.mozilla.org/attachment.cgi?id=507648&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507651: 14/19: Kill another totally unused interface,
nsIPrintStatusFeedback.
https://bugzilla.mozilla.org/attachment.cgi?id=507651&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507652: 15/19: Move remaining contents of
embedding/components/printingui to toolkit/components/printing and merge
cross-platform.
https://bugzilla.mozilla.org/attachment.cgi?id=507652&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507653: 16/19: Make the PrintDialogService scriptable, and use it
directly for print and page setup dialogs instead of going through the
PrintingPromptService.
https://bugzilla.mozilla.org/attachment.cgi?id=507653&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507654: 17/19: Remove the unnecessary Init method from
nsIPrintDialogService, and rename the vague Show method to ShowPrint.
https://bugzilla.mozilla.org/attachment.cgi?id=507654&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507655: 18/19: Kill ns(I)PrintingPromptService; use
ns(I)PrintProgress directly. En passant chainsaw cleanup of printProgress.js
and printPreviewProgress.js.
https://bugzilla.mozilla.org/attachment.cgi?id=507655&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Vladimir Vukicevic (:vlad)
<vlad...@pobox.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507656: 19/19: Fold ns(I)PrintProgressParams into
ns(I)PrintProgress.
https://bugzilla.mozilla.org/attachment.cgi?id=507656&action=edit

[bugzill...@mozilla.org]

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> has asked
Olli Pettay [:smaug] <Olli....@gmail.com> for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507647: 10/19: Remove nsIContentViewerFile and all references to

[bugzill...@mozilla.org]

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> has asked
Olli Pettay [:smaug] <Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507648: 11/19: Fold nsIPrintOptions into nsIPrintSettingsService.
https://bugzilla.mozilla.org/attachment.cgi?id=507648&action=edit

[bugzill...@mozilla.org]

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> has asked
Olli Pettay [:smaug] <Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507651: 14/19: Kill another totally unused interface,
nsIPrintStatusFeedback.
https://bugzilla.mozilla.org/attachment.cgi?id=507651&action=edit

[bugzill...@mozilla.org]

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> has asked
Olli Pettay [:smaug] <Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507654: 17/19: Remove the unnecessary Init method from

nsIPrintDialogService, and rename the vague Show method to ShowPrint.
https://bugzilla.mozilla.org/attachment.cgi?id=507654&action=edit

------- Additional Comments from Robert O'Callahan (:roc) (Mozilla Corporation)
<r...@ocallahan.org>
I think showPrintDialog would be an even better name, but I don't mind either
way.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]

<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507633: 1/19: Remove the generic XUL-based print and page setup
dialogs from toolkit/.
https://bugzilla.mozilla.org/attachment.cgi?id=507633&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507634: 2/19: Remove all references to the old print dialogs from

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507635: 3/19: Remove two totally unused nsIPrintOptions methods.
https://bugzilla.mozilla.org/attachment.cgi?id=507635&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507636: 4/19: Remove nsIPrintSettingsService.defaultPrinterName.
https://bugzilla.mozilla.org/attachment.cgi?id=507636&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507638: 5/19: Move the backend-specific code behind

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507641: 7/19: Use GetDefaultPrinterW() on Windows instead of

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507644: 8/19: Remove the remaining nsIPrinterEnumerator

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507650: 13/19: Move printingui/src/win/nsPrintDialogUtil.* to
widget/src/windows, and convert it to a nsIPrintDialogService implementation.
https://bugzilla.mozilla.org/attachment.cgi?id=507650&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507652: 15/19: Move remaining contents of

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507653: 16/19: Make the PrintDialogService scriptable, and use it

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507655: 18/19: Kill ns(I)PrintingPromptService; use

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<Olli....@gmail.com> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507656: 19/19: Fold ns(I)PrintProgressParams into
ns(I)PrintProgress.
https://bugzilla.mozilla.org/attachment.cgi?id=507656&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507634: 2/19: Remove all references to the old print dialogs from
all implementations of nsIPrintingPromptService, etc
https://bugzilla.mozilla.org/attachment.cgi?id=507634&action=edit

------- Additional Comments from Zack Weinberg (:zwol) <za...@panix.com>
Here is an updated patchset in hg bundle format. This applies on top of
http://hg.mozilla.org/mozilla-central/rev/a41fa578cfc1 and has review comments
addressed as described above. Broken-down patch series to follow. Try job
running: https://tbpl.mozilla.org/?tree=Try&rev=2453e71f42ec

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507633: 1/19: Remove the generic XUL-based print and page setup
dialogs from toolkit/.
https://bugzilla.mozilla.org/attachment.cgi?id=507633&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507655: 18/19: Kill ns(I)PrintingPromptService; use
ns(I)PrintProgress directly. En passant chainsaw cleanup of printProgress.js
and printPreviewProgress.js.
https://bugzilla.mozilla.org/attachment.cgi?id=507655&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Robert O'Callahan (:roc)
(Mozilla Corporation) <r...@ocallahan.org>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507648: 11/19: Fold nsIPrintOptions into nsIPrintSettingsService.
https://bugzilla.mozilla.org/attachment.cgi?id=507648&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507635: 3/19: Remove two totally unused nsIPrintOptions methods.
https://bugzilla.mozilla.org/attachment.cgi?id=507635&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507653: 16/19: Make the PrintDialogService scriptable, and use it
directly for print and page setup dialogs instead of going through the
PrintingPromptService.
https://bugzilla.mozilla.org/attachment.cgi?id=507653&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573652: 1/19: Remove the generic XUL-based print and page setup
dialogs from toolkit/.
https://bugzilla.mozilla.org/attachment.cgi?id=573652&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Robert O'Callahan (:roc)

(Mozilla Corporation) <r...@ocallahan.org>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507654: 17/19: Remove the unnecessary Init method from
nsIPrintDialogService, and rename the vague Show method to ShowPrint.
https://bugzilla.mozilla.org/attachment.cgi?id=507654&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Robert O'Callahan (:roc)
(Mozilla Corporation) <r...@ocallahan.org>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507651: 14/19: Kill another totally unused interface,
nsIPrintStatusFeedback.
https://bugzilla.mozilla.org/attachment.cgi?id=507651&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Robert O'Callahan (:roc)
(Mozilla Corporation) <r...@ocallahan.org>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507647: 10/19: Remove nsIContentViewerFile and all references to
nsIPrintOptions outside widget/.
https://bugzilla.mozilla.org/attachment.cgi?id=507647&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507641: 7/19: Use GetDefaultPrinterW() on Windows instead of
nsIPrinterEnumerator (which used GetProfileString!); remove the
nsIPrinterEnumerator impl.
https://bugzilla.mozilla.org/attachment.cgi?id=507641&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507638: 5/19: Move the backend-specific code behind
nsIPrintSettingsService::InitPrintSettingsFromPrinter from nsIPrinterEnumerator
to nsIDeviceContextSpec.
https://bugzilla.mozilla.org/attachment.cgi?id=507638&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507652: 15/19: Move remaining contents of
embedding/components/printingui to toolkit/components/printing and merge
cross-platform.
https://bugzilla.mozilla.org/attachment.cgi?id=507652&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507656: 19/19: Fold ns(I)PrintProgressParams into
ns(I)PrintProgress.
https://bugzilla.mozilla.org/attachment.cgi?id=507656&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507644: 8/19: Remove the remaining nsIPrinterEnumerator
implementations, which are now unused.
https://bugzilla.mozilla.org/attachment.cgi?id=507644&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507650: 13/19: Move printingui/src/win/nsPrintDialogUtil.* to
widget/src/windows, and convert it to a nsIPrintDialogService implementation.
https://bugzilla.mozilla.org/attachment.cgi?id=507650&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 507636: 4/19: Remove nsIPrintSettingsService.defaultPrinterName.
https://bugzilla.mozilla.org/attachment.cgi?id=507636&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]

<bu...@pettay.fi> for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573654: 2/19: Remove all references to the old print dialogs from

all implementations of nsIPrintingPromptService, etc

https://bugzilla.mozilla.org/attachment.cgi?id=573654&action=edit

------- Additional Comments from Zack Weinberg (:zwol) <za...@panix.com>

jst: dolske said a DOM peer should comment on
embedding/components/printingui/src/win/nsPrintDialogUtil.cpp::GetHWNDForDOMWin
dow and the XXX comment therein.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573655: 3/19: Remove two totally unused nsIPrintOptions methods and
some archaic debugging code in nsPrintOptionsImpl.cpp.
https://bugzilla.mozilla.org/attachment.cgi?id=573655&action=edit

------- Additional Comments from Zack Weinberg (:zwol) <za...@panix.com>

Requesting re-review here because I decided to go a little further than the
previous iteration, and remove a bunch of old #ifdefed-out debugging logic from
nsPrintOptionsImpl.cpp.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573657: 4/19: Remove nsIPrintSettingsService.defaultPrinterName.
https://bugzilla.mozilla.org/attachment.cgi?id=573657&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573659: 5/19: Move the backend-specific code behind

nsIPrintSettingsService::InitPrintSettingsFromPrinter from nsIPrinterEnumerator
to nsIDeviceContextSpec.

https://bugzilla.mozilla.org/attachment.cgi?id=573659&action=edit


------- Additional Comments from Zack Weinberg (:zwol) <za...@panix.com>
roc: dolske thought this was more appropriately reviewed by a widget peer, and
you've had a look at several of the other patches in this bug.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573662: 7/19: Use GetDefaultPrinterW() on Windows instead of

nsIPrinterEnumerator (which used GetProfileString!); remove the
nsIPrinterEnumerator impl.

https://bugzilla.mozilla.org/attachment.cgi?id=573662&action=edit

------- Additional Comments from Zack Weinberg (:zwol) <za...@panix.com>

jimm: dolske thought this deserved a look-over from a Windows widget peer. The
XXX comments are bug 701479.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573663: 8/19: Remove the remaining nsIPrinterEnumerator

implementations, which are now unused.

https://bugzilla.mozilla.org/attachment.cgi?id=573663&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573665: 10/19: Remove nsIContentViewerFile and all references to
nsIPrintOptions outside widget/.
https://bugzilla.mozilla.org/attachment.cgi?id=573665&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573666: 11/19: Fold nsIPrintOptions into nsIPrintSettingsService.
https://bugzilla.mozilla.org/attachment.cgi?id=573666&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573669: 13/19: Move printingui/src/win/nsPrintDialogUtil.* to

widget/src/windows, and convert it to a nsIPrintDialogService implementation.

Add a stub nsIPrintDialogService implementation for OS/2.
https://bugzilla.mozilla.org/attachment.cgi?id=573669&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573670: 14/19: Kill another totally unused interface,
nsIPrintStatusFeedback.
https://bugzilla.mozilla.org/attachment.cgi?id=573670&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573671: 15/19: Move remaining contents of

embedding/components/printingui to toolkit/components/printing and merge
cross-platform.

https://bugzilla.mozilla.org/attachment.cgi?id=573671&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573673: 16/19: Make the PrintDialogService scriptable, and use it

directly for print and page setup dialogs instead of going through the
PrintingPromptService.

https://bugzilla.mozilla.org/attachment.cgi?id=573673&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573674: 17/19: Remove the unnecessary Init method from

nsIPrintDialogService, and rename the vague Show method to ShowPrint.

https://bugzilla.mozilla.org/attachment.cgi?id=573674&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573675: 18/19: Kill ns(I)PrintingPromptService; use
ns(I)PrintProgress directly. En passant chainsaw cleanup of printProgress.js
and printPreviewProgress.js.
https://bugzilla.mozilla.org/attachment.cgi?id=573675&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]
<bu...@pettay.fi> for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573676: 19/19: Fold ns(I)PrintProgressParams into
ns(I)PrintProgress.
https://bugzilla.mozilla.org/attachment.cgi?id=573676&action=edit

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573674: 17/19: Remove the unnecessary Init method from
nsIPrintDialogService, and rename the vague Show method to ShowPrint.
https://bugzilla.mozilla.org/attachment.cgi?id=573674&action=edit

------- Additional Comments from Zack Weinberg (:zwol) <za...@panix.com>
This revision restores two accidentally-deleted ObjC interface definitions,
which were the cause of the build failures on OSX in the previous cycle.

[bugzill...@mozilla.org]

Zack Weinberg (:zwol) <za...@panix.com> has asked Olli Pettay [:smaug]

<bu...@pettay.fi> for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573995: 17/19: Remove the unnecessary Init method from

nsIPrintDialogService, and rename the vague Show method to ShowPrint.

https://bugzilla.mozilla.org/attachment.cgi?id=573995&action=edit

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:

Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

Attachment 573652: 1/19: Remove the generic XUL-based print and page setup
dialogs from toolkit/.
https://bugzilla.mozilla.org/attachment.cgi?id=573652&action=edit


------- Additional Comments from Olli Pettay [:smaug] <bu...@pettay.fi>
Removing this stuff from my review queue until the bugs blocking this
are fixed.

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500

[bugzill...@mozilla.org]

Olli Pettay [:smaug] <bu...@pettay.fi> has canceled Zack Weinberg (:zwol)
<za...@panix.com>'s request for superreview:
Bug 629500: Remove generic print dialogs and massively refactor that layer of
the printing system
https://bugzilla.mozilla.org/show_bug.cgi?id=629500