Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview requested: [Bug 860585] B2G RIL: Move cardLock related API from mozMobileConnection to mozIccManager : [Attachment 750286] Part 1: Move cardLock API from mozMobileConnection to mozIccManager (IDL), v2

4 views
Skip to first unread message

bugzill...@mozilla.org

unread,
May 16, 2013, 2:53:05 AM5/16/13
to dev-supe...@lists.mozilla.org
Edgar Chen [:edgar][:echen] <ec...@mozilla.com> has asked Jonas Sicking
(:sicking) <jo...@sicking.cc> for superreview:
Bug 860585: B2G RIL: Move cardLock related API from mozMobileConnection to
mozIccManager
https://bugzilla.mozilla.org/show_bug.cgi?id=860585

Attachment 750286: Part 1: Move cardLock API from mozMobileConnection to
mozIccManager (IDL), v2
https://bugzilla.mozilla.org/attachment.cgi?id=750286&action=edit


------- Additional Comments from Edgar Chen [:edgar][:echen]
<ec...@mozilla.com>
Hi Jonas/Yoshi:

I would like to request review for interface changes first though bug 859220 is
not landed yet. Please see comment #0 for the list of changed API. And in this
patch, I also change a event's naming from 'ICC' to 'Icc'. The latter is what
we are using in other places now.

Thanks

bugzill...@mozilla.org

unread,
May 21, 2013, 5:31:55 AM5/21/13
to dev-supe...@lists.mozilla.org
Edgar Chen [:edgar][:echen] <ec...@mozilla.com> has canceled Edgar Chen
[:edgar][:echen] <ec...@mozilla.com>'s request for superreview:
Bug 860585: B2G RIL: Move cardLock related API from mozMobileConnection to
mozIccManager
https://bugzilla.mozilla.org/show_bug.cgi?id=860585

Attachment 750286: Part 1: Move cardLock API from mozMobileConnection to
mozIccManager (IDL), v2
https://bugzilla.mozilla.org/attachment.cgi?id=750286&action=edit


------- Additional Comments from Edgar Chen [:edgar][:echen]
<ec...@mozilla.com>
Address review comment #11

bugzill...@mozilla.org

unread,
May 21, 2013, 5:31:55 AM5/21/13
to dev-supe...@lists.mozilla.org
Edgar Chen [:edgar][:echen] <ec...@mozilla.com> has asked Jonas Sicking
(:sicking) <jo...@sicking.cc> for superreview:
Bug 860585: B2G RIL: Move cardLock related API from mozMobileConnection to
mozIccManager
https://bugzilla.mozilla.org/show_bug.cgi?id=860585

Attachment 752077: Part 1: Move cardLock API from mozMobileConnection to
mozIccManager (IDL), v3, r=allstars.chh
https://bugzilla.mozilla.org/attachment.cgi?id=752077&action=edit

bugzill...@mozilla.org

unread,
Jun 12, 2013, 1:14:33 AM6/12/13
to dev-supe...@lists.mozilla.org
Jonas Sicking (:sicking) <jo...@sicking.cc> has granted Edgar Chen
[:edgar][:echen] <ec...@mozilla.com>'s request for superreview:
Bug 860585: B2G RIL: Move cardLock related API from mozMobileConnection to
mozIccManager
https://bugzilla.mozilla.org/show_bug.cgi?id=860585

Attachment 752077: Part 1: Move cardLock API from mozMobileConnection to
mozIccManager (IDL), v3, r=allstars.chh
https://bugzilla.mozilla.org/attachment.cgi?id=752077&action=edit


------- Additional Comments from Jonas Sicking (:sicking) <jo...@sicking.cc>
Review of attachment 752077:
-----------------------------------------------------------------

As long as the RIL owners are ok with this, I am.

bugzill...@mozilla.org

unread,
Jun 12, 2013, 1:25:32 PM6/12/13
to dev-supe...@lists.mozilla.org
Edgar Chen [:edgar][:echen] <ec...@mozilla.com> has granted superreview:
Bug 860585: B2G RIL: Move cardLock related API from mozMobileConnection to
mozIccManager
https://bugzilla.mozilla.org/show_bug.cgi?id=860585

Attachment 761524: Part 1: Move cardLock API from mozMobileConnection to
mozIccManager (IDL), v4, r=allstars.chh, sr=sicking
https://bugzilla.mozilla.org/attachment.cgi?id=761524&action=edit


------- Additional Comments from Edgar Chen [:edgar][:echen]
<ec...@mozilla.com>
1). Rebase
2). Add sr=sicking after sr+
0 new messages