superreview requested: [Bug 868431] IonMonkey: Require baseline compilation, remove bailout-to-interpreter code : [Attachment 752305] Patch

[bugzill...@mozilla.org]

Jan de Mooij [:jandem] <jdem...@mozilla.com> has asked David Anderson
[:dvander] <dva...@alliedmods.net> for superreview:
Bug 868431: IonMonkey: Require baseline compilation, remove
bailout-to-interpreter code
https://bugzilla.mozilla.org/show_bug.cgi?id=868431

Attachment 752305: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=752305&action=edit


------- Additional Comments from Jan de Mooij [:jandem] <jdem...@mozilla.com>
The OSR-from-the-interpreter and bailout-to-interpreter code is unused now with
Baseline and Ion enabled and it's complicating stack refactoring work.

The attached patch removes it and disables Ion when Baseline is disabled.

13 files changed, 39 insertions(+), 920 deletions(-)

[bugzill...@mozilla.org]

David Anderson [:dvander] <dva...@alliedmods.net> has granted Jan de Mooij
[:jandem] <jdem...@mozilla.com>'s request for superreview:

Bug 868431: IonMonkey: Require baseline compilation, remove
bailout-to-interpreter code
https://bugzilla.mozilla.org/show_bug.cgi?id=868431

Attachment 752305: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=752305&action=edit

------- Additional Comments from David Anderson [:dvander]
<dva...@alliedmods.net>
Review of attachment 752305:
-----------------------------------------------------------------

It begins!

[bugzill...@mozilla.org]

Jan de Mooij [:jandem] <jdem...@mozilla.com> has granted superreview:

Bug 868431: IonMonkey: Require baseline compilation, remove
bailout-to-interpreter code
https://bugzilla.mozilla.org/show_bug.cgi?id=868431

Attachment 752649: Patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=752649&action=edit


------- Additional Comments from Jan de Mooij [:jandem] <jdem...@mozilla.com>
Forces a Baseline compile with --ion-eager, so that we can directly enter Ion.
This caught a (pre-existing) bug, patch for that coming up too.