superreview requested: [Bug 611451] Mac OS X shared libraries export all symbols : [Attachment 689571] Use the -exported_symbols_list linker option instead of the nmedit command

[bugzill...@mozilla.org]

Wan-Teh Chang <w...@google.com> has asked Kai Engert (:kaie) <ka...@kuix.de> for
superreview:
Bug 611451: Mac OS X shared libraries export all symbols
https://bugzilla.mozilla.org/show_bug.cgi?id=611451

Attachment 689571: Use the -exported_symbols_list linker option instead of the
nmedit command
https://bugzilla.mozilla.org/attachment.cgi?id=689571&action=edit


------- Additional Comments from Wan-Teh Chang <w...@google.com>
This patch implements the suggestion in the nmedit warning message.
I verified it works on Mac OS X 10.8.2 with Xcode 4.5.1.

I am worried that the -exported_symbols_list linker option won't
work on the NSS Mac/ppc tinderbox. Kai, could you test it?

[bugzill...@mozilla.org]

Wan-Teh Chang <w...@google.com> has asked Mark Mentovai <ma...@moxienet.com> for

superreview:
Bug 611451: Mac OS X shared libraries export all symbols
https://bugzilla.mozilla.org/show_bug.cgi?id=611451

Attachment 689571: Use the -exported_symbols_list linker option instead of the
nmedit command
https://bugzilla.mozilla.org/attachment.cgi?id=689571&action=edit


------- Additional Comments from Wan-Teh Chang <w...@google.com>

Mark, could you review this patch? This is the NSS equivalent of
your patch in bug 403250. Thanks.

[bugzill...@mozilla.org]

Mark Mentovai <ma...@moxienet.com> has granted Wan-Teh Chang <w...@google.com>'s
request for superreview: