Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview requested: [Bug 1531826] Debug eval sources is broken and opens the index HTML file : [Attachment 9048211] Part 3 - Convert source IDs in console API stacks.

2 views
Skip to first unread message

Bugzilla@Mozilla

unread,
Mar 4, 2019, 11:50:03 AM3/4/19
to dev-supe...@lists.mozilla.org
Brian Hackett (:bhackett) <bhacke...@gmail.com> has asked Logan Smyth
[:loganfsmyth] <lsm...@mozilla.com> for superreview:
Bug 1531826: Debug eval sources is broken and opens the index HTML file
https://bugzilla.mozilla.org/show_bug.cgi?id=1531826

Attachment 9048211: Part 3 - Convert source IDs in console API stacks.
https://bugzilla.mozilla.org/attachment.cgi?id=9048211&action=edit



--- Comment #8 from Brian Hackett (:bhackett) <bhacke...@gmail.com> ---
Created attachment 9048211
--> https://bugzilla.mozilla.org/attachment.cgi?id=9048211&action=edit
Part 3 - Convert source IDs in console API stacks.

Console API messages can have stack traces if console.trace() was used, in
which case we need to convert the internal source IDs to source actor IDs.
This fixes the links in frames of the console.trace() call so that they go to
the right debugger source.


--

Bugzilla@Mozilla

unread,
Mar 6, 2019, 2:10:00 PM3/6/19
to dev-supe...@lists.mozilla.org
Logan Smyth [:loganfsmyth] <lsm...@mozilla.com> has reassigned Brian Hackett
(:bhackett) <bhacke...@gmail.com>'s request for superreview:
0 new messages