superreview requested: [Bug 1531826] Debug eval sources is broken and opens the index HTML file : [Attachment 9047905] patch

[Bugzilla@Mozilla]

Brian Hackett (:bhackett) <bhacke...@gmail.com> has asked Patrick Brosset
<:pbro> <pbro...@mozilla.com> for superreview:
Bug 1531826: Debug eval sources is broken and opens the index HTML file
https://bugzilla.mozilla.org/show_bug.cgi?id=1531826

Attachment 9047905: patch
https://bugzilla.mozilla.org/attachment.cgi?id=9047905&action=edit



--- Comment #5 from Brian Hackett (:bhackett) <bhacke...@gmail.com> ---
Created attachment 9047905
--> https://bugzilla.mozilla.org/attachment.cgi?id=9047905&action=edit
patch

This fixes the problem with the first STR for me. The event listener
server/client code keeps track of a source actor ID that can be passed to
viewSourceInDebugger to go to the source containing the event listener's
script. (Asking sr? because the r? flag in bugzilla has been disabled and I
haven't figured out how to use phabricator yet.)

The second STR is still broken, I'll look at this one as well.


--

[Bugzilla@Mozilla]

Patrick Brosset <:pbro> <pbro...@mozilla.com> has reassigned Brian Hackett
(:bhackett) <bhacke...@gmail.com>'s request for superreview to Alexandre
Poirot [:ochameau] <poiro...@gmail.com>:

Bug 1531826: Debug eval sources is broken and opens the index HTML file
https://bugzilla.mozilla.org/show_bug.cgi?id=1531826

Attachment 9047905: patch
https://bugzilla.mozilla.org/attachment.cgi?id=9047905&action=edit

--- Comment #6 from Patrick Brosset <:pbro> <pbro...@mozilla.com> ---
Comment on attachment 9047905
--> https://bugzilla.mozilla.org/attachment.cgi?id=9047905
patch

Review of attachment 9047905:
-----------------------------------------------------------------

Passing this on to Alex who will be a much better reviewer than me on these
server changes.


--

[Bugzilla@Mozilla]

Alexandre Poirot [:ochameau] <poiro...@gmail.com> has reassigned Brian
Hackett (:bhackett) <bhacke...@gmail.com>'s request for superreview: