superreview requested: [Bug 1532362] Breakpoints don't work in evaled sources : [Attachment 9048275] patch

[Bugzilla@Mozilla]

Brian Hackett (:bhackett) <bhacke...@gmail.com> has asked Logan Smyth
[:loganfsmyth] <lsm...@mozilla.com> for superreview:
Bug 1532362: Breakpoints don't work in evaled sources
https://bugzilla.mozilla.org/show_bug.cgi?id=1532362

Attachment 9048275: patch
https://bugzilla.mozilla.org/attachment.cgi?id=9048275&action=edit



--- Comment #1 from Brian Hackett (:bhackett) <bhacke...@gmail.com> ---
Created attachment 9048275
--> https://bugzilla.mozilla.org/attachment.cgi?id=9048275&action=edit
patch

The problem here is related to the '//# sourceURL=my-foo.js' in the eval'ed
source, which assigns a URL to the source which the client can use. When the
client wants to set a breakpoint in that source, it sends the URL down to the
server, but then the server goes and compares the URL with the
Debugger.Source's .url property, which is a different value
("http://whatever/script.js line 8 > eval"). I think it would make more sense
to use the actor's .url property, which is almost the same as what was sent up
to the client. (The source actor's form actually sends 'this.url.split(" ->
").pop()'; I don't know what this is for but hopefully it is no longer
necessary.)


--

[Bugzilla@Mozilla]

Logan Smyth [:loganfsmyth] <lsm...@mozilla.com> has reassigned Brian Hackett
(:bhackett) <bhacke...@gmail.com>'s request for superreview: