superreview requested: [Bug 757664] Make the files attribute of HTMLInputElement writable : [Attachment 628895] patch

[bugzill...@mozilla.org]

Mounir Lamouri (:volkmar) (:mounir) <mou...@lamouri.fr> has asked Jonas Sicking
(:sicking) <jo...@sicking.cc> for superreview:
Bug 757664: Make the files attribute of HTMLInputElement writable
https://bugzilla.mozilla.org/show_bug.cgi?id=757664

Attachment 628895: patch
https://bugzilla.mozilla.org/attachment.cgi?id=628895&action=edit


------- Additional Comments from Mounir Lamouri (:volkmar) (:mounir)
<mou...@lamouri.fr>
Review of attachment 628895:
-----------------------------------------------------------------

r=me with the requested changes.

Though, this needs a super-review from Jonas.

::: content/html/content/test/forms/test_input_files_writable.html
@@ +34,5 @@
> +netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
> +input1.mozSetFileNameArray(myFile, myFile.length);
> +
> +input2.files = input1.files;
> +is(input2.files.length, 1, "files attribute should be writable");

I would really prefer something like that:
caught = false;
try {
input2.files = input1.files;
} catch(e) {
caught = true;
}
is(caught, false, "files attribute should be writable");
is(input2.files.length, 1, "setting the files attribute should have updated
it");

[bugzill...@mozilla.org]

tha...@chromium.org has canceled Mounir Lamouri (:volkmar) (:mounir)
<mou...@lamouri.fr>'s request for superreview:

Bug 757664: Make the files attribute of HTMLInputElement writable
https://bugzilla.mozilla.org/show_bug.cgi?id=757664

Attachment 628895: patch
https://bugzilla.mozilla.org/attachment.cgi?id=628895&action=edit

------- Additional Comments from tha...@chromium.org
With the requested test change.

[bugzill...@mozilla.org]

tha...@chromium.org has asked Jonas Sicking (:sicking) <jo...@sicking.cc> for

superreview:
Bug 757664: Make the files attribute of HTMLInputElement writable
https://bugzilla.mozilla.org/show_bug.cgi?id=757664

Attachment 629233: patch
https://bugzilla.mozilla.org/attachment.cgi?id=629233&action=edit

[bugzill...@mozilla.org]

Jonas Sicking (:sicking) <jo...@sicking.cc> has canceled tha...@chromium.org's
request for superreview:

Bug 757664: Make the files attribute of HTMLInputElement writable
https://bugzilla.mozilla.org/show_bug.cgi?id=757664

Attachment 629233: patch
https://bugzilla.mozilla.org/attachment.cgi?id=629233&action=edit

------- Additional Comments from Jonas Sicking (:sicking) <jo...@sicking.cc>
Review of attachment 629233:
-----------------------------------------------------------------

I'll let mounir make a decision here. I still think that we should implement
the ability to do

inputElement.files = [blob1, blob2];

That should be pretty easy to implement once bug 825196 is fixed so that we can
use webidl. Using WebIDL would also mean that passing a FileList would
JustWork(tm) if I understand things correctly.

Maybe something Andrea is interested in taking on since he's been doing a lot
of work on HTMLInputElement lately.

[bugzill...@mozilla.org]

Mounir Lamouri (:mounir) <mou...@lamouri.fr> has not granted superreview:

Bug 757664: Make the files attribute of HTMLInputElement writable
https://bugzilla.mozilla.org/show_bug.cgi?id=757664

Attachment 629233: patch
https://bugzilla.mozilla.org/attachment.cgi?id=629233&action=edit

------- Additional Comments from Mounir Lamouri (:mounir) <mou...@lamouri.fr>
Marking sr- to make clear the patch is fine but we want to hold the landing for
the moment.