Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview requested: [Bug 838839] Remove deprecated synchronous favicons APIs : [Attachment 711005] patch v1.0

2 views
Skip to first unread message

bugzill...@mozilla.org

unread,
Feb 26, 2013, 2:56:27 PM2/26/13
to dev-supe...@lists.mozilla.org
Marco Bonardo [:mak] (Away Mar 1) <ma...@bonardo.net> has asked :Gavin Sharp
(use ga...@gavinsharp.com for email) <gavin...@gmail.com> for superreview:
Bug 838839: Remove deprecated synchronous favicons APIs
https://bugzilla.mozilla.org/show_bug.cgi?id=838839

Attachment 711005: patch v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=711005&action=edit


------- Additional Comments from Marco Bonardo [:mak] (Away Mar 1)
<ma...@bonardo.net>
Review of attachment 711005:
-----------------------------------------------------------------

I must unbitrot the patch due to recent changes to notify deprecation, though
we can proceed with SR in parallel to the review

bugzill...@mozilla.org

unread,
Feb 28, 2013, 4:35:36 AM2/28/13
to dev-supe...@lists.mozilla.org
Marco Bonardo [:mak] (Away Mar 1) <ma...@bonardo.net> has asked :Gavin Sharp
(use ga...@gavinsharp.com for email) <gavin...@gmail.com> for superreview:
Bug 838839: Remove deprecated synchronous favicons APIs
https://bugzilla.mozilla.org/show_bug.cgi?id=838839

Attachment 719398: patch v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=719398&action=edit


------- Additional Comments from Marco Bonardo [:mak] (Away Mar 1)
<ma...@bonardo.net>
just an unbitrot

bugzill...@mozilla.org

unread,
Feb 28, 2013, 4:35:36 AM2/28/13
to dev-supe...@lists.mozilla.org
Marco Bonardo [:mak] (Away Mar 1) <ma...@bonardo.net> has canceled Marco
Bonardo [:mak] (Away Mar 1) <ma...@bonardo.net>'s request for superreview:
Bug 838839: Remove deprecated synchronous favicons APIs
https://bugzilla.mozilla.org/show_bug.cgi?id=838839

Attachment 711005: patch v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=711005&action=edit


bugzill...@mozilla.org

unread,
Feb 28, 2013, 12:50:44 PM2/28/13
to dev-supe...@lists.mozilla.org
:Gavin Sharp (use ga...@gavinsharp.com for email) <gavin...@gmail.com> has
granted Marco Bonardo [:mak] (Away Mar 1) <ma...@bonardo.net>'s request for
superreview:
Bug 838839: Remove deprecated synchronous favicons APIs
https://bugzilla.mozilla.org/show_bug.cgi?id=838839

Attachment 719398: patch v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=719398&action=edit


------- Additional Comments from :Gavin Sharp (use ga...@gavinsharp.com for
email) <gavin...@gmail.com>
The forward declaration of nsIFaviconDataCallback at the top of
nsIFaviconService should no longer be needed.
0 new messages