superreview requested: [Bug 179033] enable ignore/kill / watch for mail (and mail filters) : [Attachment 747384] proposed fix

[bugzill...@mozilla.org]

Magnus Melin <mkmelin...@iki.fi> has asked Mark Banner (:standard8)
<mba...@mozilla.com> for superreview:
Bug 179033: enable ignore/kill / watch for mail (and mail filters)
https://bugzilla.mozilla.org/show_bug.cgi?id=179033

Attachment 747384: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=747384&action=edit


------- Additional Comments from Magnus Melin <mkmelin...@iki.fi>
This enables igonore thread, ignore subthread and watch thread for mail too.

Related changes and bugfixes in this patch

- for mail, ignoring a message will show a notification on the bottom of the
thread pane, allowing access to undo and a learn more button

- ignore thread/subthread disabled (in ui code) for multi-thread
selection. otherwise the ui for disabling is futhrer complicated, and if you

don't notice it may cause a lot of damage. don't see the use case for it
anyway...

- toggling View | Threads | Ignore Threads didn't apply correctly

- selectionsummaries now work with ignored subthreads

- removed some dead css from osx searchdialog.css - afaikt we never show
threads there at all..

Sent to try:
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/mkm...@iki.fi-10
88d52e4603

[bugzill...@mozilla.org]

Magnus Melin <mkmelin...@iki.fi> has canceled Magnus Melin
<mkmelin...@iki.fi>'s request for superreview:

Bug 179033: enable ignore/kill / watch for mail (and mail filters)
https://bugzilla.mozilla.org/show_bug.cgi?id=179033

Attachment 747384: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=747384&action=edit


------- Additional Comments from Magnus Melin <mkmelin...@iki.fi>

Addressing review comments. I've added the context menu items, but no buttons
yet. Also I've added some mozmill tests.

[bugzill...@mozilla.org]

Magnus Melin <mkmelin...@iki.fi> has asked Mark Banner (:standard8)

<mba...@mozilla.com> for superreview:

Bug 179033: enable ignore/kill / watch for mail (and mail filters)
https://bugzilla.mozilla.org/show_bug.cgi?id=179033

Attachment 758136: proposed fix, v2
https://bugzilla.mozilla.org/attachment.cgi?id=758136&action=edit

[bugzill...@mozilla.org]

Magnus Melin <mkmelin...@iki.fi> has canceled Magnus Melin

<mkmelin...@iki.fi>'s request for superreview:

Bug 179033: enable ignore/kill / watch for mail (and mail filters)
https://bugzilla.mozilla.org/show_bug.cgi?id=179033

Attachment 758136: proposed fix, v2
https://bugzilla.mozilla.org/attachment.cgi?id=758136&action=edit


------- Additional Comments from Magnus Melin <mkmelin...@iki.fi>

Removed the enable ignore pref. Also made sure the icons show in non-threaded
view. (Except for grouped by sort view, but that hides the thread col so...)
It's not super-nice for ignored subthreads to have the same icon as the start
of ignored subthread essage, maybe we should consider another icon for those,
as a followup?

[bugzill...@mozilla.org]

Magnus Melin <mkmelin...@iki.fi> has asked Mark Banner (:standard8)

<mba...@mozilla.com> for superreview:

Bug 179033: enable ignore/kill / watch for mail (and mail filters)
https://bugzilla.mozilla.org/show_bug.cgi?id=179033

Attachment 761984: proposed fix, v3
https://bugzilla.mozilla.org/attachment.cgi?id=761984&action=edit

[bugzill...@mozilla.org]

Mark Banner (:standard8) <mba...@mozilla.com> has granted Magnus Melin
<mkmelin...@iki.fi>'s request for superreview:

Bug 179033: enable ignore/kill / watch for mail (and mail filters)
https://bugzilla.mozilla.org/show_bug.cgi?id=179033

Attachment 761984: proposed fix, v3
https://bugzilla.mozilla.org/attachment.cgi?id=761984&action=edit

------- Additional Comments from Mark Banner (:standard8) <mba...@mozilla.com>
Ok, this was fine for me, apart from the fact that a couple of the newly added
strings should have been using PluralForm. Given where we are, I went and fixed
that and got r=mconley over irc.

Here's the two changesets I just landed:

https://hg.mozilla.org/comm-central/rev/9abe445f3c60
https://hg.mozilla.org/comm-central/rev/c40e235d5144