superreview requested: [Bug 829952] Scrolling using some high-resolution-scroll aware touchpads feels slow : [Attachment 724842] Patch

[bugzill...@mozilla.org]

Masayuki Nakano (:masayuki) (Mozilla Japan) <masa...@d-toybox.com> has asked
Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> for
superreview:
Bug 829952: Scrolling using some high-resolution-scroll aware touchpads feels
slow
https://bugzilla.mozilla.org/show_bug.cgi?id=829952

Attachment 724842: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=724842&action=edit


------- Additional Comments from Masayuki Nakano (:masayuki) (Mozilla Japan)
<masa...@d-toybox.com>
This regression is caused by my wrong decision. I assumed that high-resolution
support pointing devices set good scroll speed and have their own acceleration
system.

However, actually, the logged environment supports high resolution scroll but
the user feels the speed slow.

So, I think that when pointing device doesn't customize the scrolling speed, we
should always use "system scroll speed override".

And for reducing the run time cost of calls
nsIWidget::OverrideSystemMouseScrollSpeed(), we should redesign its arguments
for D3E WheelEvent. And now, we support higher resolution scroll before
implementing D3E WheelEvent. Therefore, OverrideSystemMouseScrollSpeed() is
called higher frequently. So, I think that we should cache the pref values into
static variables.

[bugzill...@mozilla.org]

Masayuki Nakano (:masayuki) (Mozilla Japan) <masa...@d-toybox.com> has

canceled Masayuki Nakano (:masayuki) (Mozilla Japan) <masa...@d-toybox.com>'s
request for superreview:

Bug 829952: Scrolling using some high-resolution-scroll aware touchpads feels
slow
https://bugzilla.mozilla.org/show_bug.cgi?id=829952

Attachment 724842: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=724842&action=edit


------- Additional Comments from Masayuki Nakano (:masayuki) (Mozilla Japan)
<masa...@d-toybox.com>

Thank you, smaug and avih!

[bugzill...@mozilla.org]

Masayuki Nakano (:masayuki) (Mozilla Japan) <masa...@d-toybox.com> has asked

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> for

superreview:
Bug 829952: Scrolling using some high-resolution-scroll aware touchpads feels
slow
https://bugzilla.mozilla.org/show_bug.cgi?id=829952

Attachment 725207: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=725207&action=edit

[bugzill...@mozilla.org]

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> has granted
Masayuki Nakano (:masayuki) (Mozilla Japan) <masa...@d-toybox.com>'s request