Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview granted: [Bug 1531826] Debug eval sources is broken and opens the index HTML file : [Attachment 9048209] Part 2 - Allow clicking on my-foo.js console message links.

0 views
Skip to first unread message

Bugzilla@Mozilla

unread,
Mar 5, 2019, 5:27:21 AM3/5/19
to dev-supe...@lists.mozilla.org
Nicolas Chevobbe <nche...@mozilla.com> has granted Brian Hackett (:bhackett)
<bhacke...@gmail.com>'s request for superreview:
Bug 1531826: Debug eval sources is broken and opens the index HTML file
https://bugzilla.mozilla.org/show_bug.cgi?id=1531826

Attachment 9048209: Part 2 - Allow clicking on my-foo.js console message links.
https://bugzilla.mozilla.org/attachment.cgi?id=9048209&action=edit



--- Comment #12 from Nicolas Chevobbe <nche...@mozilla.com> ---
Comment on attachment 9048209
--> https://bugzilla.mozilla.org/attachment.cgi?id=9048209
Part 2 - Allow clicking on my-foo.js console message links.

So, this should only affect the message location (i.e. the link on the right of
a message).
Frames in stacktrace (including those from console.trace) are using a different
component (`SmartTrace`), but it looks like it's already using sourceId
([devtools/client/shared/components/SmartTrace.js#212](https://searchfox.org/mo
zilla-central/source/devtools/client/shared/components/SmartTrace.js#212)).
We should make sure to have a test for this test case.


--
0 new messages