superreview requested: [Bug 856410] Implement futures : [Attachment 747507] part 4 - Future.reject, Future.resolve

[bugzill...@mozilla.org]

Mounir Lamouri (:mounir) <mou...@lamouri.fr> has asked Jonas Sicking (:sicking)
<jo...@sicking.cc> for superreview:
Bug 856410: Implement futures
https://bugzilla.mozilla.org/show_bug.cgi?id=856410

Attachment 747507: part 4 - Future.reject, Future.resolve
https://bugzilla.mozilla.org/attachment.cgi?id=747507&action=edit


------- Additional Comments from Mounir Lamouri (:mounir) <mou...@lamouri.fr>
Review of attachment 747507:
-----------------------------------------------------------------

So, the code looks good but I'm not sure we want that for our first
implementation. I am not sure of much people want that and even less how much
they would use .reject() (I could see a tiny use case for .resolve()).

I will let Jonas make the call whether we should that with the first batch of
patches or not.

::: dom/future/tests/test_future.html
@@ +249,5 @@
> }
>
> +function futureReject() {
> + var future = Future.reject(42).done(function(what) {
> + }, function(what) {

Could you add a ok(false, "..."); in the success callback?

@@ +259,5 @@
> +function futureResolve() {
> + var future = Future.resolve(42).done(function(what) {
> + is(what, 42, "Value == 42");
> + runTest();
> + });

Same here for the reject callback.

[bugzill...@mozilla.org]

Andrea Marchesini (:baku) <amarc...@mozilla.com> has canceled Mounir Lamouri
(:mounir) <mou...@lamouri.fr>'s request for superreview:

[bugzill...@mozilla.org]

Andrea Marchesini (:baku) <amarc...@mozilla.com> has asked Jonas Sicking
(:sicking) <jo...@sicking.cc> for superreview:

Bug 856410: Implement futures
https://bugzilla.mozilla.org/show_bug.cgi?id=856410

Attachment 751327: part 4 - Future.reject, Future.resolve
https://bugzilla.mozilla.org/attachment.cgi?id=751327&action=edit

[bugzill...@mozilla.org]

Jonas Sicking (:sicking) <jo...@sicking.cc> has canceled Andrea Marchesini
(:baku) <amarc...@mozilla.com>'s request for superreview:

Bug 856410: Implement futures
https://bugzilla.mozilla.org/show_bug.cgi?id=856410

Attachment 751327: part 4 - Future.reject, Future.resolve
https://bugzilla.mozilla.org/attachment.cgi?id=751327&action=edit

------- Additional Comments from Jonas Sicking (:sicking) <jo...@sicking.cc>
Review of attachment 751327:
-----------------------------------------------------------------

I'm going to punt this over to David Herman as a feedback request. David, would
be great if you could put the feedback from TC39 in this bug. That way we can
make sure to implement a compatible subset of the current TC39 suggestion (or
is "agreement" the right noun to use).