Proposal: kill wafflejs in a fire

[Ricky Rosario]

tl;dr: Every single page view to the site generates a request for
/wafflejs. The benefit of having access to waffles in js is questionable
and there are workarounds. We should remove it.

If you go to kitsune/sumo/static/js and grep for waffle:

$ git grep waffle
browserid.js: if (!waffle.flag_is_active('browserid')) {

We are only using it once and it's for Persona (we should kill Persona
but that email is coming next). We are generating 1.5 to 2 million
requests to Apache+Django per day for this. It must die.

So, from now on, we should never check flags like this from js. If we
absolutely need to know whether a waffle is on or off, we should add a
data-* attribute to the <body/> or similar.

Any objections?

BTW, the requests for /<locale>/jsi18n/build:<build_id> are just as
problematic. I already submitted a pull request, so they should be gone
soon too: https://bugzilla.mozilla.org/show_bug.cgi?id=952642

Happy Friday!
-Ricky

[Ricky Rosario]

I filed a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=972832

[Kadir Topal]

Ha, that's funny, I was looking at page load times around the world
yesterday and wanted to suggest that we act on this. The Waffle JS can
take a long time to load in certain countries and it blocks loading a
bunch of other things. In Sao Paolo for example it took almost 2 seconds
just to load Waffle JS (all included). I'm attaching a few comparison
cities.

--Kadir

Ricky Rosario schrieb:

> _______________________________________________
> dev-sumo mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-sumo

[Kadir Topal]

Looks like the list strips off attachments.

Sao Paolo: http://note.io/1lO2eMQ
Prag: http://note.io/Mj8Vdh
San Diego: http://note.io/1lO2iwb

--Kadir

Kadir Topal schrieb: