DXR UI refresh is live!

[Erik Rose]

https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/

Happy hacking!

[Taras Glek]

that's pretty, but where did the list of classes & class members go when viewing files like http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp

----- Original Message -----
> From: "Erik Rose" <er...@mozilla.com>
> To: dev-pl...@lists.mozilla.org, dev-stati...@lists.mozilla.org
> Sent: Friday, February 7, 2014 1:26:19 PM
> Subject: DXR UI refresh is live!
>
> https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
>
> Happy hacking!
> _______________________________________________
> dev-static-analysis mailing list
> dev-stati...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-static-analysis
>

[Erik Rose]

> that's pretty, but where did the list of classes & class members go when viewing files like http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp

Coming back soon: https://bugzilla.mozilla.org/show_bug.cgi?id=965659. We're having some trouble reducing it to a test case smaller than moz-central.

[Tom Schuster]

The design looks really fresh, I really like the new colors. I am however
wondering about additional spaces that were introduced, they seem to even
break indentation:
http://dxr.mozilla.org/mozilla-central/source/js/src/jsapi.cpp#1426.

-Tom

> _______________________________________________
> dev-platform mailing list
> dev-pl...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>

[Erik Rose]

Fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=969887#c1. It will take effect with the next re-index, in a few hours.

Good eye! Somehow, nobody caught this on staging or locally, though it seems obvious in retrospect. While I was at it, I stopped the code from jumping to the side when you click a long line number; that was silly, too. Keep the feedback coming, pro and con. We already have many little things on the chopping block: see the high-ID bugs at https://bugzilla.mozilla.org/buglist.cgi?product=Webtools&component=DXR&resolution=---&list_id=9393813. And of course, patches are welcome. :-)

Cheers,
Erik

[Reed Loden]

On Fri, 7 Feb 2014 16:26:19 -0500
Erik Rose <er...@mozilla.com> wrote:

> https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
>
> Happy hacking!

I do like the slickness and quickness, but it still seems
greatly-lacking usability-wise (as compared to mxr)...

A few things off the top of my head:
* Where are the non-mozilla-central repositories?
* Where's the integration with CVS?
* Where are the links to see changes over the last day, week, month,
etc.?
* Why do I have to click on "Navigation" just to get basic
functionality?
* Why is it not accessible over SSL?

~reed

[Robert O'Callahan]

On Wed, Feb 12, 2014 at 9:18 AM, Reed Loden <re...@reedloden.com> wrote:

> I do like the slickness and quickness, but it still seems
> greatly-lacking usability-wise (as compared to mxr)...
>
> A few things off the top of my head:
> * Where are the non-mozilla-central repositories?
> * Where's the integration with CVS?
>
* Where are the links to see changes over the last day, week, month,
> etc.?

> * Why is it not accessible over SSL?
>

Personally I'm glad the team prioritized the work they did over these
features.

Rob
--
Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni
le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa
stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr,
'm aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp
waanndt wyeonut thoo mken.o w

[Erik Rose]

Hi, Reed. Rest assured, many of your wishes are planned for the future. But when you have a big project, you've got to pick some things.

Last week's release was an important milestone: it was the minimal feature set that would yield a cohesive experience under a UI new design. The new design solves a lot of usability problems, removes some serious limitations, and gives us places to put several things planned for the near future. Now, ordinarily, I abhor big-red-lever launches, as evidenced by our continued rollout of features onto production while the UI work was in progress and the fact that we deployed 7 times yesterday. However, you can't always iterate your way to big user-facing changes and make sense the whole time. So don't take the current state as an end; it's just an uncharacteristically large step, worthy of a release announcement.

Let me address your individual wishes:

> * Where are the non-mozilla-central repositories?

Coming! One of the big UI-branch features is improved support for multiple trees. The UI for that is hidden right now, since there's only one tree indexed. But we're working on comm-central right now. Aurora is next. Then we'll continue pulling in more, in order of the popularity they see on MXR. I think you'll like what you see.

> * Where's the integration with CVS?
> * Where are the links to see changes over the last day, week, month,
> etc.?

A lower priority since there are plenty of other ways to poll version control. However, we have a flexible framework for VCS integration (https://github.com/mozilla/dxr/blob/master/dxr/plugins/omniglot/htmlifier.py), and this would be an easy first bug, if it's important to you. (If you can get a bunch of people to hoot and holler about how important it is, we'll move it up the roadmap.)

> * Why do I have to click on "Navigation" just to get basic functionality?

That was already ticketed, and I fixed it yesterday; the nav pane is now disclosed by default. More is planned: https://bugzilla.mozilla.org/show_bug.cgi?id=968020.

> * Why is it not accessible over SSL?

There's an IT bug filed about that, but indexing more trees is higher priority right now. Do you have a specific use case in mind?

Feel free to have a look at our roadmap (https://wiki.mozilla.org/DXR_Roadmap) and add constructively to it.

Cheers,
Erik

[Erik Rose]

> that's pretty, but where did the list of classes & class members go when viewing files like http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp

I believe this is fixed now, a casualty of a needless use of JS, which is now gone. If you still see this behavior, please reopen https://bugzilla.mozilla.org/show_bug.cgi?id=965659.

Thanks for riding out the bumps!

Erik

[Ehsan Akhgari]

On 2/11/2014, 3:18 PM, Reed Loden wrote:
> On Fri, 7 Feb 2014 16:26:19 -0500
> Erik Rose <er...@mozilla.com> wrote:
>
>> https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
>>
>> Happy hacking!
>

> I do like the slickness and quickness, but it still seems
> greatly-lacking usability-wise (as compared to mxr)...

Can you please clarify how DXR is greatly-lacking usability-wise?

> A few things off the top of my head:

> * Where are the non-mozilla-central repositories?

There is ongoing work on multi-repository support.

> * Where's the integration with CVS?
> * Where are the links to see changes over the last day, week, month,
> etc.?

> * Why do I have to click on "Navigation" just to get basic
> functionality?

> * Why is it not accessible over SSL?

I don't think any of these are important features for us to focus on. I
would say that we accept patches for the last three items, but I don't
think we are interested in accepting patches for CVS support into DXR.

Cheers,
Ehsan

[Taras Glek]

Very happy now :)

> Erik Rose <mailto:er...@mozilla.com>
> Tuesday, February 11, 2014 14:50

>
> I believe this is fixed now, a casualty of a needless use of JS, which
> is now gone. If you still see this behavior, please reopen
> https://bugzilla.mozilla.org/show_bug.cgi?id=965659.
>
> Thanks for riding out the bumps!
>
> Erik

> Taras Glek <mailto:tg...@mozilla.com>
> Friday, February 7, 2014 14:42

> that's pretty, but where did the list of classes & class members go
> when viewing files like
> http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp
>

> ----- Original Message -----
> _______________________________________________
> dev-static-analysis mailing list
> dev-stati...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-static-analysis

> Erik Rose <mailto:er...@mozilla.com>
> Friday, February 7, 2014 13:26

[Joshua Cranmer 🐧]

On 2/11/2014 5:00 PM, Ehsan Akhgari wrote:
> I don't think any of these are important features for us to focus on.
> I would say that we accept patches for the last three items, but I
> don't think we are interested in accepting patches for CVS support
> into DXR.
>

This statement is worth slightly qualifying: adding links to bonsai for
CVS trees on DXR would be fine. Any deeper integration is almost
certainly not worth the time.

On the other hand, since I think we have no remaining active projects on
CVS, it may be worthwhile to convert the entire history of mozilla CVS
into an appropriate DVCS (hg or git, I don't really care) and use that
repo in DXR instead of the CVS tree.

--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

[Ehsan Akhgari]

On 2/11/2014, 6:24 PM, Joshua Cranmer 🐧 wrote:
> On the other hand, since I think we have no remaining active projects on
> CVS, it may be worthwhile to convert the entire history of mozilla CVS
> into an appropriate DVCS (hg or git, I don't really care) and use that
> repo in DXR instead of the CVS tree.

https://github.com/ehsan/mozilla-cvs-history :-)

Cheers,
Ehsan