Hello all,
Just quickly commenting on comments :D
On Tue, Mar 8, 2016 at 2:18 AM, mermi <
mane...@gmail.com> wrote:
> I have a remark about the Indexes on main page, I think the icon should be in the
> right and the words near to it!
I have no hard feelings about icons being on right or left.
On Tue, Mar 8, 2016 at 4:46 PM, Augustin Trancart
<
augustin...@phoxygen.com> wrote:
> There is one difference I've seen with Firefox OS: in the "Indexes on main
> page", we have opted to right-align everything in RTL to have a more
> consistent UI in the history page on FxOS. I personally would find it
> cleaner, instead of having items that align differently, but maybe that's
> clearer that way for an arabic reader, I don't know.
Again no hard feelings for icons, but I myself prefer texts being
bidirectional like it is now. It mean that the text gets right/left
aligned based on the context. So if it's Latin alphabet, it shows them
LTR and on Arabic/Hebrew RTL. This also makes sense for address bar
(because most URLs are with Latin alphabet and they seem weird to when
they are RTL, although Firefox is doing the same).
> For toolbars, such as the one on top of the "Main Menu (Priority 1)" with
> favorites, add tab and share buttons: I *think* we ended up mirroring their
> order in FxOS (we changed that halfway 2.5).
I think this one is valid. The discussion about being right/left
handed came up in Sri Lanka too, and I'm not really agreed with it.
Currently smartphones are having big screens that you can't work with
them with only one hand and most people use both hands. So I think
being right/left handed shouldn't be a big concern.
> - On the same page, shouldn't the site favicons be on the right side for rtl
> UI for each item in the list? (I assume they are on the left for LTR UI
> right?). It would be more consistent with the favicon position in the url
> bar and in the tab title, as can be seen in the "tabs and address bar"
> section.
You mean the ones in "Indexes on main page"?
> - On the "tab index page" section, I noticed the "x" icon is still on the
> right in RTL. Shouldn't they be on the left? It would be more consistent
> with the "x" icon on tabs in the "tabs and address bar" section.
It makes sense. (but titles are bidirectional, so maybe not a priority)
I can do that for sure. Are everybody done discussing? I can prepare
the fixes tomorrow.
Best Wishes,
Arash