Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

iOS Work

4 views
Skip to first unread message

Stefan Arentz

unread,
May 6, 2016, 3:45:46 PM5/6/16
to Dev...@lists.mozilla.org
Hello everyone,

Yesterday Delphine pointed me to the review that has been done for Firefox for iOS and the PDF attached to  https://bugzilla.mozilla.org/show_bug.cgi?id=1160759.

That is really fantastic work. We knew there were gaps in our RTL support so it is very nice to see it spelled out so clearly. It translates easily into concrete bugs that my team can start fixing.

This is a bit of a stretch goal, but I am going to try to get us fix most of these things before MozLondon. I’d love to have a discussion there and maybe a review of that work and also look at a bunch of new UI that we have been introducing recently.

 S.

R ehb

unread,
May 6, 2016, 4:08:37 PM5/6/16
to Stefan Arentz, Dev...@lists.mozilla.org
Hi,
Thank you, if you need any further help please let me know.

Bests,
Reza




_______________________________________________
Dev-rtl mailing list
Dev...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-rtl


Stefan Arentz

unread,
May 6, 2016, 4:48:12 PM5/6/16
to R ehb, Dev...@lists.mozilla.org

> On May 6, 2016, at 4:08 PM, R ehb <reza.ha...@gmail.com> wrote:
>
> Hi,
> Thank you, if you need any further help please let me know.

In the Reading List, we have these Remove and Mark as Read buttons that appear when you swipe a row to the left or right:

https://www.dropbox.com/s/32xssc75o42njoo/Screenshot%202016-05-06%2016.46.14.png?dl=0

Should those buttons switch sided on RTL?

S.

Stefan Arentz

unread,
May 6, 2016, 4:51:23 PM5/6/16
to R ehb, Dev...@lists.mozilla.org

> On May 6, 2016, at 4:08 PM, R ehb <reza.ha...@gmail.com> wrote:
>
> Hi,
> Thank you, if you need any further help please let me know.

Last question for today. We have a lot of tables that look like this:

https://www.dropbox.com/s/fhy12nq8ewnfnkh/Screenshot%202016-05-06%2016.49.38.png?dl=0

Should the icons move to the right side?

Is the general rule, “mirror the layout"?

S.

R ehb

unread,
May 6, 2016, 4:58:35 PM5/6/16
to Stefan Arentz, Dev...@lists.mozilla.org
I thought for swipe and Icons we can use Default buttons for RTL.


On Sat, May 7, 2016 at 1:18 AM, Stefan Arentz <sar...@mozilla.com> wrote:

> On May 6, 2016, at 4:08 PM, R ehb <reza.ha...@gmail.com> wrote:
>
> Hi,
> Thank you, if you need any further help please let me know.

Stefan Arentz

unread,
May 6, 2016, 4:58:49 PM5/6/16
to R ehb, Dev...@lists.mozilla.org

> On May 6, 2016, at 4:08 PM, R ehb <reza.ha...@gmail.com> wrote:
>
> Hi,
> Thank you, if you need any further help please let me know.

Ok, one more question :-)

The empty top sites page now looks like this:

https://www.dropbox.com/s/l9oqwzkt5g9t7cn/Screenshot%202016-05-06%2016.54.40.png?dl=0

Am I correct that the order of these default tiles needs to change from:

Facebook Youtube Amazon
Wikipedia Twitter

To:

Amazon YouTube Facebook
Twitter Wikipedia

So first item is top right, rows are right aligned

Do we follow this rule everywhere where we display things in a grid like that?

S.

Mohamed Hafez

unread,
May 6, 2016, 5:09:51 PM5/6/16
to Stefan Arentz, Dev...@lists.mozilla.org, R ehb
yes, i think first item should be in top right, rows are right aligned
​ ​
and care about the free space always in left
​.​



 S.

_______________________________________________
Dev-rtl mailing list
Dev...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-rtl



--
photo
Mohamed Hafez
Mozilla Rep, Chairman Mozilla Egypt Community
       

Stefan Arentz

unread,
May 6, 2016, 5:11:00 PM5/6/16
to R ehb, Dev...@lists.mozilla.org

> On May 6, 2016, at 4:58 PM, R ehb <reza.ha...@gmail.com> wrote:
>
> I thought for swipe and Icons we can use Default buttons for RTL.

I’m not sure. I just changed my iPhone to Arabic and in Mail.app, the blue “unread” indicator dot moves to the right side and the buttons under the swipe left/right on a row also switch sides. I guess that makes sense because we want to keep the “Mark as Read” button on the same side as the indicator dot.

Shall we follow what Mail.app does?

S.

Stefan Arentz

unread,
May 6, 2016, 5:49:28 PM5/6/16
to Mohamed Hafez, Dev...@lists.mozilla.org, R ehb

On May 6, 2016, at 5:40 PM, Mohamed Hafez <mohame...@gmail.com> wrote:

i think Reza you miss to swap Twitter and Wikipedia top sites, i know that not important but make it clear of serialization of top site always began from right like this:

3

2

1

6

5

4

 

8

7

 

thanks

Thanks for the clarification.

I’m surprised the top sites are not layout like that in RTL now because we use a UICollectionView for those, and it should automatically adapt the order. Something odd is going on there.

 S.

0 new messages