Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Changing how Popcorn Maker loads Popcorn
39 views
Skip to first unread message
Jon Buckley
Mar 6, 2013, 6:06:24 PM3/6/13
to Community discussion list for Mozilla Popcorn, dev-popcorn@lists.mozilla.org Dev
Hey folks, I'm working on a patch for Popcorn Maker that changes how Popcorn is loaded in the published project. Work is happening in https://webmademovies.lighthouseapp.com/projects/65733/tickets/3305
I'm removing the list of Popcorn plugins from the Cornfield config, and instead listing them inside src/embed.js. The end goal is to get rid of the duplicate configs all around the butter repo (src/default-config.json, per-template config, cornfield config), have a single place that lists Popcorn things, and let RequireJS do the hard work of dependency ordering and loading.
TL;DR: If you add your own plugins or wrappers to cornfield's exportAssets block, you'll need to move those to src/embed.js.
Jon
I'm removing the list of Popcorn plugins from the Cornfield config, and instead listing them inside src/embed.js. The end goal is to get rid of the duplicate configs all around the butter repo (src/default-config.json, per-template config, cornfield config), have a single place that lists Popcorn things, and let RequireJS do the hard work of dependency ordering and loading.
TL;DR: If you add your own plugins or wrappers to cornfield's exportAssets block, you'll need to move those to src/embed.js.
Jon
0 new messages