new Mac OS X appshell impl, bug 395397
josh...@gmail.com
Mac OS X appshell implementation that Steven Michaud recently
finished. It has r/sr but we wanted to run it by everyone before
approving and landing it. This email is just to prep people on the
subject in case anyone wants to join the discussion.
The bug is 395397. The patch was written by Steven Michaud and
thoroughly reviewed by me, Mark Mentovai and Robert O'Callahan. Steven
did a bunch of testing and is unaware of any regressions. Here are the
reasons why we want to take this patch:
1. It fixes major blocker bug 356720, which is about events not being
processed during certain UI interactions. For example, without it
simply navigating the native menu bar will pause YouTube video
playback. This is a regression.
2. It is most likely the biggest win for perceived performance that
we'll see on the Mac between now and the Gecko 1.9 release. It makes
the browsing experience much more smooth under certain common
conditions.
3. It gives us better modal dialog and nested event loop handling (bug
338225).
4. Our current appshell's code is worrisome and fragile, this new
appshell is "the right way to do it." We're less likely to have
problems with it in the future.
5. It fixes other various more minor bugs.
6. The patch for it is very contained and easy to back out should
something go wrong.
Gijs Kruitbosch
I don't have a say in this or any real comments, but I'm wondering if
this fixes or affects
https://bugzilla.mozilla.org/show_bug.cgi?id=395042 . Do you have a
quick answer on that? If not, I guess just land it and we'll see, as
it's broken as-is anyway... ;-)
~ Gijs