Rust 1.10 (to be) required to build Firefox with --enable-rust

101 views
Skip to first unread message

Nathan Froyd

unread,
Aug 10, 2016, 9:19:01 AM8/10/16
to dev-platform
TL; DR: As the subject says, although the patch is not yet on
mozilla-central. You may want to pre-emptively update your Rust
before the build system requires you to.

We've not been particularly aggressive with requiring new Rust
versions, but with the release of 1.10, we wanted to start compiling
Firefox with '-C panic=abort'. Bug 1268727 tracks that work; patches
for said bug have landed on mozilla-inbound and seem likely to merge
to mozilla-central later today/this week. The configure machinery
will check the Rust version that you have and refuse to proceed
further if you don't have a new enough version.

Thanks,
-Nathan

Dave Townsend

unread,
Aug 10, 2016, 10:57:08 AM8/10/16
to Nathan Froyd, dev-platform
Does MozillaBuild include the appropriate version of rust?
> _______________________________________________
> dev-platform mailing list
> dev-pl...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>

Nathan Froyd

unread,
Aug 10, 2016, 11:17:46 AM8/10/16
to Dave Townsend, dev-platform
It does not...though judging from:

https://hg.mozilla.org/mozilla-build/file

it looks like we don't include Rust in MozillaBuild currently
regardless, as Rust is an optional build dependency at this point. (I
could be mistaken about Rust's inclusion, but clicking through files
revealed no obvious mentions of Rust.)

I filed bug 1294083[1] to track/discuss.

Thanks
-Nathan

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1294083

Gregory Szorc

unread,
Aug 10, 2016, 11:28:53 AM8/10/16
to Nathan Froyd, dev-platform, Dave Townsend
I'll be marking that bug wontfix as soon as I get in front of a computer with my BMO credentials. We plan to have no more releases of MozillaBuild.

There is support for installing Rust via rustup in 'mach bootstrap'. That requires an msys2 environment, which we should be rolling out soon. In the interim, just use rustup manually.

Ted Mielczarek

unread,
Aug 10, 2016, 1:47:17 PM8/10/16
to Gregory Szorc, Nathan Froyd, dev-platform
On Wed, Aug 10, 2016, at 11:28 AM, Gregory Szorc wrote:
> I'll be marking that bug wontfix as soon as I get in front of a computer
> with my BMO credentials. We plan to have no more releases of
> MozillaBuild.
>
> There is support for installing Rust via rustup in 'mach bootstrap'. That
> requires an msys2 environment, which we should be rolling out soon. In
> the interim, just use rustup manually.

Wasn't bootstrapping rust in MozillaBuild already fixed by bug
1177128[1]?

-Ted

1. https://bugzilla.mozilla.org/show_bug.cgi?id=1177128

Stefan Sitter

unread,
Aug 10, 2016, 1:54:47 PM8/10/16
to
On 10.08.2016 17:28, Gregory Szorc wrote:
> I'll be marking that bug wontfix as soon as I get in front of a
> computer with my BMO credentials. We plan to have no more releases of
> MozillaBuild.

What will be the new way to get all build dependencies and tools for
Windows platform when MozillaBuild is discontinued?

/Stefan

Gregory Szorc

unread,
Aug 10, 2016, 2:13:13 PM8/10/16
to Ted Mielczarek, dev-platform, Nathan Froyd
On Wed, Aug 10, 2016 at 10:46 AM, Ted Mielczarek <t...@mielczarek.org> wrote:

> On Wed, Aug 10, 2016, at 11:28 AM, Gregory Szorc wrote:
> > I'll be marking that bug wontfix as soon as I get in front of a computer
> > with my BMO credentials. We plan to have no more releases of
> > MozillaBuild.
> >
> > There is support for installing Rust via rustup in 'mach bootstrap'. That
> > requires an msys2 environment, which we should be rolling out soon. In
> > the interim, just use rustup manually.
>
> Wasn't bootstrapping rust in MozillaBuild already fixed by bug
> 1177128[1]?
>
> -Ted
>
> 1. https://bugzilla.mozilla.org/show_bug.cgi?id=1177128


Oh, right. I forgot we made a separate bootstrapper for MozillaBuild versus
msys2. So just run `mach bootstrap` in MozillaBuild and Rust things should
happen.

Gregory Szorc

unread,
Aug 10, 2016, 2:14:01 PM8/10/16
to Stefan Sitter, dev-platform
On Wed, Aug 10, 2016 at 10:54 AM, Stefan Sitter <ssitte...@gmail.com>
wrote:
Yes.

Jared Wein

unread,
Aug 10, 2016, 2:57:20 PM8/10/16
to Gregory Szorc, dev-platform, Stefan Sitter
On Wed, Aug 10, 2016 at 2:13 PM, Gregory Szorc <g...@mozilla.com> wrote:

> On Wed, Aug 10, 2016 at 10:54 AM, Stefan Sitter <ssitte...@gmail.com>
> wrote:
>
> Yes.
>

"Yes" ??? I'm not sure you understood the question here? Stefan, and myself
included, are curious what the new way to get all build deps after
MozillaBuild is discontinued.

Will the new procedure be to install Mercurial and Python, open the Windows
console, then clone mozilla-central, then run `mach bootstrap` ? Asking
users to install mercurial and python by themselves seems like a regression
to me.

Thanks,
Jared

Gregory Szorc

unread,
Aug 10, 2016, 6:29:52 PM8/10/16
to Jared Wein, dev-platform, Stefan Sitter, Gregory Szorc
On Wed, Aug 10, 2016 at 11:56 AM, Jared Wein <ja...@mozilla.com> wrote:

> On Wed, Aug 10, 2016 at 2:13 PM, Gregory Szorc <g...@mozilla.com> wrote:
>
>> On Wed, Aug 10, 2016 at 10:54 AM, Stefan Sitter <ssitte...@gmail.com>
>> wrote:
>>
>> Yes.
>>
>
> "Yes" ??? I'm not sure you understood the question here? Stefan, and
> myself included, are curious what the new way to get all build deps after
> MozillaBuild is discontinued.
>
> Will the new procedure be to install Mercurial and Python, open the
> Windows console, then clone mozilla-central, then run `mach bootstrap` ?
> Asking users to install mercurial and python by themselves seems like a
> regression to me.
>

I hope you don't think we'd increase the complexity of getting a Windows
development environment configured :)

We'll offer a standalone file that can be executed to install the
development environment.

Philip Chee

unread,
Aug 20, 2016, 12:26:49 PM8/20/16
to
Your snarky answer isn't very helpful.

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

Philip Chee

unread,
Aug 20, 2016, 12:30:11 PM8/20/16
to
On 11/08/2016 06:29, Gregory Szorc wrote:

> We'll offer a standalone file that can be executed to install the
> development environment.

Isn't MozillaBuild "a standalone file that can be executed to install
the development environment."

Phil (totally unclear of the difference)

Nicholas Nethercote

unread,
Aug 21, 2016, 7:00:54 AM8/21/16
to Philip Chee, dev-platform
On Sun, Aug 21, 2016 at 2:30 AM, Philip Chee <phili...@gmail.com> wrote:
>
>> We'll offer a standalone file that can be executed to install the
>> development environment.
>
> Isn't MozillaBuild "a standalone file that can be executed to install
> the development environment."

MozillaBuild unzips into lots of files and programs. It's a whole
programming environment.

AIUI, gps is referring to something more like a single script. I.e.
basically just run "mach bootstrap" and everything is done for you, as
is the case on Mac and Linux.

Nick
Reply all
Reply to author
Forward
0 new messages