MemShrink Pre-Triage (28th June 2016)

[Eric Rahm]

We've missed the last two triages due to PTO and the London all-hands, so the list is a bit large today. If there's enough feedback and no additions to the meeting agenda we can skip the in-person meeting tomorrow.

MemShrink triage: 2016-06-28

Triage URL: http://mzl.la/1yYeaGL

Agenda

(Add name and topic to discuss here)

Bug List

Vote for:

• P1 High importance, will follow up periodically
• P2 Important issue, possibly already being worked on
• P3 Real issue, someone will get to it if they have time
• moreinfo We need logs, or clarifying information
• invalid Misclassified, remove the MemShrink tag

24 bugs to triage

• 904867 - Core :: ImageLib - Memory keeps going up and up in self-refreshing pages at flickr

  Votes:

• 1181127 - Core :: DOM: Service Workers - Implement service worker event handler spec changes for no-fetch optimization

  Votes:

• 1261869 - Firefox :: Developer Tools: Memory - DevTools are leaking windows (and other objects) across refreshes, until DevTools are closed

  Votes:

  mccr8, what do you think?

• 1266915 - Core :: DOM - twitter leaks a lot of orphan nodes through window refresh

  Votes:

  mccr8, erahm, what do you think?

• 1270298 - Firefox :: Untriaged - OOM crash on code.org tutorial running in a VM

  Votes:

  mccr8, erahm, what do you think?

• 1272078 - Core :: DOM - Leak of dom/memory-file-data entries persists after disabling addon

  Votes:

  khuey, erahm, what do you think?

• 1273735 - Firefox :: Untriaged - Possible Memory Leak on Firefox

  Votes:

  mccr8, what do you think?

• 1275280 - Core :: DOM - consider converting to one-byte strings in dom bindings

  Votes:

  erahm, what do you think?

• 1277376 - Core :: DOM - twitter can leak overlay windows until all twitter tabs are closed

  Votes:

• 1277397 - Core :: ImageLib - High memory usage triggered by a jpg

  Votes:

• 1277630 - Firefox :: Pocket - browser.xul window leaked through fir...@getpocket.com addon

  Votes:

• 1277722 - Core :: DOM: Events - youtube window leaked through Touch object

  Votes:

• 1277892 - Firefox :: SocialAPI - consider lazy loading social-sidebar-browser xul

  Votes:

• 1278726 - Firefox :: Developer Tools: Memory - devtools memory panel leaks windows on sites using iframes with postMessage

  Votes:

  mccr8, what do you think?

• 1278731 - Firefox :: Developer Tools: Memory - devtools memory panel uses a lot of heap-uncategorized memory

  Votes:

  erahm, what do you think?

• 1279035 - Core :: DOM - Memory spike running the "DOM Modification" dromaeo test

  Votes:

• 1279121 - Hello (Loop) :: General - loop appears to leak blob URLs

  Votes:

• 1279389 - Toolkit :: OS.File - Enable osfile.reset_worker_delay on all products

  Votes:

• 1279757 - Firefox :: Untriaged - Firefox doesn't clean up its memory

  Votes:

  erahm, what do you think?

• 1279760 - Core :: DOM - Tremendous resource consumption upon loading the Satoshi Matrix Top 100 NES game list

  Votes:

• 1280916 - Firefox :: Untriaged - Memory leak when using Content Security Policy and WebSockets

  Votes:

  khuey, erahm, mccr8, what do you think?

• 1281725 - Core :: ImageLib - Refuse to allocate a huge deinterlacing buffer in the PNG decoder

  Votes:

• 1281728 - Core :: DOM - many ghost windows

  Votes:

• 1282163 - Core :: DOM - att.com leaks windows

  Votes:

  khuey, what do you think?

[Nick Fitzgerald]

On Tue, Jun 28, 2016 at 10:02 AM, Eric Rahm <er...@mozilla.com> wrote:

• 1261869 - Firefox :: Developer Tools: Memory - DevTools are leaking windows (and other objects) across refreshes, until DevTools are closed

​I dug into this, but hit a wall where​ I couldn't get any useful information on why things were retained. I don't know how to proceed with it, but I consider it high priority since the tool for debugging memory leaks shouldn't be causing leaks and getting in the way of you debugging your own leaks!

Would love some advice on how to proceed here, see comments in the bug for where I got stuck.

• 1278726 - Firefox :: Developer Tools: Memory - devtools memory panel leaks windows on sites using iframes with postMessage

​I suspect this is related to the last one, but I haven't looked into it specifically.​ Maybe a dupe? Have been putting it off until I figure out the other and was planning on revisiting afterwards to see if it still reproduces.

 

• 1278731 - Firefox :: Developer Tools: Memory - devtools memory panel uses a lot of heap-uncategorized memory

  ​​

​I don't think there is any low hanging fruit for reducing the size of deserialized heap snapshots, although there certainly are some things we could try.

I would be up for adding the deserialized heap snapshots to about:memory reporting so that they don't show up as heap-uncategorized. Just need some pointers on what that process looks like (ni'd erahm in the bug).

[Andrew McCreight]

On Tue, Jun 28, 2016 at 10:02 AM, Eric Rahm <er...@mozilla.com> wrote:

24 bugs to triage

• 904867 - Core :: ImageLib - Memory keeps going up and up in self-refreshing pages at flickr

  Votes:

P2? Maybe P1? It sounds like under some circumstances we're retaining too many images. I don't know how common that is.

• 1181127 - Core :: DOM: Service Workers - Implement service worker event handler spec changes for no-fetch optimization

P2. Seems like a solid improvement to avoid some of the impact of a new feature.

• Votes:

• 1261869 - Firefox :: Developer Tools: Memory - DevTools are leaking windows (and other objects) across refreshes, until DevTools are closed

• Votes:

• mccr8, what do you think?

Maybe P2?

• 1266915 - Core :: DOM - twitter leaks a lot of orphan nodes through window refresh

Sounds bad, but I don't know how common it is.

• Votes:

  mccr8, erahm, what do you think?

• 1270298 - Firefox :: Untriaged - OOM crash on code.org tutorial running in a VM

P2? Seems less important due to the VM part. 

• Votes:

  mccr8, erahm, what do you think?

• 1272078 - Core :: DOM - Leak of dom/memory-file-data entries persists after disabling addon

P2? I don't know if this is just something triggered by an addon, or if the addon is doing something unusual.
 

• Votes:

  khuey, erahm, what do you think?

• 1273735 - Firefox :: Untriaged - Possible Memory Leak on Firefox

I dunno. P2? It seems like there's bad stuff here but I don't know if it is actionable.
 

• Votes:

  mccr8, what do you think?

• 1275280 - Core :: DOM - consider converting to one-byte strings in dom bindings

  Votes:

  erahm, what do you think?

• 1277376 - Core :: DOM - twitter can leak overlay windows until all twitter tabs are closed

Sounds bad if Twitter is doing this frequently. P2? Maybe P1?
 

• Votes:

• 1277397 - Core :: ImageLib - High memory usage triggered by a jpg

P2, this is a jpg generated by a fuzzer. It sounds bad but hopefully these kinds of images don't exist in the wild.
 

• Votes:

• 1277630 - Firefox :: Pocket - browser.xul window leaked through fir...@getpocket.com addon

P2 I guess?

• Votes:

• 1277722 - Core :: DOM: Events - youtube window leaked through Touch object

Sounds bad. I don't know who is going to work on it.

• Votes:

• 1277892 - Firefox :: SocialAPI - consider lazy loading social-sidebar-browser xul

  Votes:

• 1278726 - Firefox :: Developer Tools: Memory - devtools memory panel leaks windows on sites using iframes with postMessage

  Votes:

• mccr8, what do you think?

I don't know what is appropriate for leaks in a particular devtool.

• 1278731 - Firefox :: Developer Tools: Memory - devtools memory panel uses a lot of heap-uncategorized memory

• Votes:

• erahm, what do you think?

• 1279035 - Core :: DOM - Memory spike running the "DOM Modification" dromaeo test

Just leave this untriaged for now. It could be bad. It would be interesting to know if the spike is more reasonable without e10s.
 

• Votes:

• 1279121 - Hello (Loop) :: General - loop appears to leak blob URLs

P2 maybe?

• Votes:

• 1279389 - Toolkit :: OS.File - Enable osfile.reset_worker_delay on all products

P2? decent win.

• Votes:

• 1279757 - Firefox :: Untriaged - Firefox doesn't clean up its memory

Need to wait some more for analysis.

• Votes:

  erahm, what do you think?

• 1279760 - Core :: DOM - Tremendous resource consumption upon loading the Satoshi Matrix Top 100 NES game list

This is mostly JS stuff. Can't do much unless we can do something very fancy with sharing memory across compartments.

• Votes:

• 1280916 - Firefox :: Untriaged - Memory leak when using Content Security Policy and WebSockets

Need more analysis.

• Votes:

  khuey, erahm, mccr8, what do you think?

• 1281725 - Core :: ImageLib - Refuse to allocate a huge deinterlacing buffer in the PNG decoder

  Votes:

• 1281728 - Core :: DOM - many ghost windows

  Votes:

• 1282163 - Core :: DOM - att.com leaks windows

  Votes:

  khuey, what do you think?

_______________________________________________
dev-memory mailing list
dev-m...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-memory