Making unreviewed suggestions easier to find in Pontoon

[Matjaz Horvat]

Hi,

We're changing the review process in Pontoon by introducing the ability to
reject suggestions instead of deleting them.

Each suggestion can now be approved, unreviewed or rejected. This will
finally make it easy to list all suggestions needing a review using the
newly introduced Unreviewed Suggestions filter.

See the new review states in action:
https://blog.mozilla.org/l10n/files/2017/08/reject.png

Read more on the blog:
https://blog.mozilla.org/l10n/2017/08/10/making-unreviewed-suggestions-easier-to-find/

To make the filter usable out of the box, all existing suggestions have
been automatically rejected if an approved translation was available and
approved after the suggestion has been submitted.

The final step in making unreviewed suggestions truly discoverable is to
show them in dashboards, which is coming up as part of bug 1377969.

A huge shout-out to Adrian Gaudebert, who only joined Pontoon team in July
and already managed to contribute this important patch!

Cheers,
Matjaž

[Michal Stanke]

Great news. I am looking forward to the dashboard changes!

One question, or maybe two. From which translatioslns the machinery takes
in case the string has been removed? Think of a scenario when the ID has
been change.

What happens, when I make a typo and want to fix it immediately. Does it
mean it will stay in the history forever?

--
Michal Stanke

Dne 10. 8. 2017 14:25 napsal uživatel "Matjaz Horvat" <mat...@mozilla.com>:

_______________________________________________
dev-l10n mailing list
dev-...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-l10n

[Alfredos (fredy) Damkalis]

Great news! I was waiting for it, it will be a very useful tool for me!

Thanks Matjaz and Andrian!

I've read in the blog post that if a suggestion was submitted before the
approved translation then it is marked as rejected.

Would be possible/easy to make an exception on it for a locale and mark
as unreviewed all the suggestions that are not the same with the
approved translation? I would like to revisit and reject myself some of
the older suggestions or not selected suggestions.

Thanks,
fredy

[Matjaz Horvat]

On Thu, Aug 10, 2017 at 2:53 PM, Michal Stanke <mst...@mozilla.cz> wrote:
> Great news. I am looking forward to the dashboard changes!

Yeah, having the number of suggestions on the dashboard is the missing
piece in the puzzle.

> One question, or maybe two. From which translatioslns the machinery takes
> in case the string has been removed? Think of a scenario when the ID has
> been change.

We only keep approved translations in the internal Pontoon translation
memory. Once the translation is rejected (or previously, deleted),
it's no longer in the TM. Does that answer your question?

> What happens, when I make a typo and want to fix it immediately. Does it
> mean it will stay in the history forever?

Yes and I understand this can be tricky sometimes. OTOH tracking the
entire history bring several benefits. For example, wouldn't it be
great if Pontoon could send you a notification that the
approved/rejected ratio of a new contributor started to improve so
much that you should consider giving her Translator permissions? Of
course, not all rejected strings are equally bad (they might have even
been approved in the past), so we'd need to fine-tune the idea. But
with the ability to delete translations things like this are hardly
possible.

On Thu, Aug 10, 2017 at 3:40 PM, Alfredos (fredy) Damkalis
<fr...@fredy.gr> wrote:
> I've read in the blog post that if a suggestion was submitted before the
> approved translation then it is marked as rejected.

To be precise, suggestions we automatically rejected were submitted
before the approved translation was *approved*. So someone must have
already seen them.

> Would be possible/easy to make an exception on it for a locale and mark
> as unreviewed all the suggestions that are not the same with the
> approved translation? I would like to revisit and reject myself some of
> the older suggestions or not selected suggestions.

Pontoon doesn't allow duplicate suggestions, so all rejected entries
are different from the approved translations. If you want to revisit
older entries, you can use the Rejected filter.

-Matjaž

[Jordi Serratosa]

Hi Matjaz,

It seems that the "rejected" translations are still being included in
the bilingual TMX (translation memory). Previously I could at least
manually (!) delete the wrong/rejected translations using the Trash icon
so that I could get a clean TMX. Now the trash icon is gone, so I do not
know how to get a clean TMX anymore. I only want a clean TMX with all
the approved translations from a project.

Am I missing something?

salut,
jordi s

[Matjaz Horvat]

On Sat, Aug 12, 2017 at 7:12 PM, Jordi Serratosa <jordis...@gmail.com> wrote:
> It seems that the "rejected" translations are still being included in the
> bilingual TMX (translation memory). Previously I could at least manually (!)
> delete the wrong/rejected translations using the Trash icon so that I could
> get a clean TMX. Now the trash icon is gone, so I do not know how to get a
> clean TMX anymore.

Hey Jordi,

If you click on the reject icon, translation gets removed from the
Translation Memory the same way it was removed when you clicked on the
trash icon.

That said, if approved translation gets rejected (or previously,
unapproved) *implicitly* by submitting a better approved translation,
it stays in the TM. Let's fix this:
https://bugzilla.mozilla.org/show_bug.cgi?id=1390047

On Sat, Aug 12, 2017 at 7:12 PM, Jordi Serratosa <jordis...@gmail.com> wrote:
> I only want a clean TMX with all the approved translations from a project.

Right, but take into account that the translation memory also contains
historic data for obsolete strings and projects. Strings like "Tab
Groups" that are no longer used in Firefox stay in the TM.

-Matjaž