Correcting built-in search engine (DIEC) for Catalan in Fennec

[Jordi Serratosa]

Hi,

One of the Catalan search engines changed URL and needs to be modified.
Tested in Android Firefox 79.1.0-beta.1 (Build #2015753459) and Nightly.

The search engine is DIEC2.
Wrong URL: https://dlc.iec.cat/?txtEntrada=|{searchTerms}|&operEntrada=0
Correct URL:
https://dlc.iec.cat/results.asp?txtEntrada=|{searchTerms}|&OperEntrada=0

Could somebody point me in the direction to address that?

Thank you!

salut,
jordi s

|
|

[Francesco Lodolo]

Hi Jordi,

To update existing search engines we need a bug filed in Firefox::Search.

Having said that, I checked the URL and it seems already correct to me.
https://searchfox.org/mozilla-central/source/browser/components/search/extensions/diec2/manifest.json#22

It tried installing locally that search engines, and creating a new
profile with a Catalan nightly, and it works correctly in both cases.

Which version of Firefox are you using? In about:support, which
version of DIEC2 do you see listed?

Francesco

Il giorno sab 1 ago 2020 alle ore 21:59 Jordi Serratosa
<jordis...@gmail.com> ha scritto:

> _______________________________________________
> dev-l10n mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-l10n

[Jordi Serratosa]

Hi Francesco,
I was referring to Android, not sure if you picked that. Just tested in
Nightly 200801 06:06 (Build #22140616)

Are search engines shared between desktop and mobile versions?


salut,
jordi s

El dg., 2 d’ag. 2020, 6:49, Francesco Lodolo <fl...@lodolo.net> va escriure:

[Francesco Lodolo]

Sorry, completely missed the Android part (also because I didn't
realize we had them customized per locale).

Leaving this to Delphine, because I don't know anything about
searchplugins on Fenix. I wonder if they mirrored an old version of
what Firefox was using, in which case Catalan might not be the only
one with issues.

Francesco

Il giorno dom 2 ago 2020 alle ore 12:54 Jordi Serratosa

[Axel Hecht]

The engine is in a-c,
https://github.com/mozilla-mobile/android-components/blob/master/components/browser/search/src/main/assets/searchplugins/diec2.xml.

Maybe a redirect on the site broke? As it's using the `mdlc` host (note
the leading `m`).

Axel

Am 02.08.20 um 12:57 schrieb Francesco Lodolo:

[Delphine L]

Thanks for surfacing all this, I'll follow-up with the mobile team and
follow-up here.

cheers

--
Delphine

[Delphine L]

Quick update: I've filed an issue in the a-c repository for this, so
hopefully this will be resolved soon :)
cheers

On Mon, Aug 3, 2020 at 8:47 AM Delphine L <lebedel....@gmail.com>
wrote:

> Thanks for surfacing all this, I'll follow-up with the mobile team and
> follow-up here.
>
> cheers
>
> On Sun, Aug 2, 2020 at 8:15 AM Axel Hecht <ax...@mozilla.com> wrote:
>

> --
> Delphine
>


--
Delphine

[Jordi Serratosa]

Hi Delhpine, can you share the bug? I'm not sure whether more action is
needed on my part yo address this issue for Catalan.

salut,
jordi s

El 04/08/2020 a les 0:28, Delphine L ha escrit:
> Quick update: I've filed an issue in the a-c repository for this, so
> hopefully this will be resolved soon :)
> cheers
>
> On Mon, Aug 3, 2020 at 8:47 AM Delphine L <lebedel....@gmail.com>
> wrote:
>
>> Thanks for surfacing all this, I'll follow-up with the mobile team and
>> follow-up here.
>>
>> cheers
>>
>> On Sun, Aug 2, 2020 at 8:15 AM Axel Hecht <ax...@mozilla.com> wrote:
>>

>> --
>> Delphine
>>
>

[Delphine L]

Hi Jordi,

This is the issue:
https://github.com/mozilla-mobile/android-components/issues/7963
It's on the mobile team's radar, but hasn't received any traction yet.

I'll follow-up soon if I still don't see any progress.

thanks!

On Sun, Aug 9, 2020 at 6:40 AM Jordi Serratosa <jordis...@gmail.com>
wrote:

> Hi Delhpine, can you share the bug? I'm not sure whether more action is
> needed on my part yo address this issue for Catalan.
>
> salut,
> jordi s
>
>
> El 04/08/2020 a les 0:28, Delphine L ha escrit:
> > Quick update: I've filed an issue in the a-c repository for this, so
> > hopefully this will be resolved soon :)
> > cheers
> >
> > On Mon, Aug 3, 2020 at 8:47 AM Delphine L <lebedel....@gmail.com>
> > wrote:
> >
> >> Thanks for surfacing all this, I'll follow-up with the mobile team and
> >> follow-up here.
> >>
> >> cheers
> >>
> >> On Sun, Aug 2, 2020 at 8:15 AM Axel Hecht <ax...@mozilla.com> wrote:
> >>

> >> --
> >> Delphine

> >>
> >
> _______________________________________________
> dev-l10n mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-l10n
>

--
Delphine

[Jordi Serratosa]

Thank you, Delphine. I created a pull request that should fix the
engine. I'm not sure whether that's the right way to go.

salut,
jordi s

El 10/08/2020 a les 19:06, Delphine L ha escrit:
> Hi Jordi,
>
> This is the issue:
> https://github.com/mozilla-mobile/android-components/issues/7963
> <https://github.com/mozilla-mobile/android-components/issues/7963>
> It's on the mobile team's radar, but hasn't received any traction yet.
>
> I'll follow-up soon if I still don't see any progress.
>
> thanks!
>
> On Sun, Aug 9, 2020 at 6:40 AM Jordi Serratosa <jordis...@gmail.com
> <mailto:jordis...@gmail.com>> wrote:
>
> Hi Delhpine, can you share the bug? I'm not sure whether more
> action is
> needed on my part yo address this issue for Catalan.
>
> salut,
> jordi s
>
>
> El 04/08/2020 a les 0:28, Delphine L ha escrit:
> > Quick update: I've filed an issue in the a-c repository for this, so
> > hopefully this will be resolved soon :)
> > cheers
> >
> > On Mon, Aug 3, 2020 at 8:47 AM Delphine L

> <lebedel....@gmail.com <mailto:lebedel....@gmail.com>>

> > wrote:
> >
> >> Thanks for surfacing all this, I'll follow-up with the mobile
> team and
> >> follow-up here.
> >>
> >> cheers
> >>
> >> On Sun, Aug 2, 2020 at 8:15 AM Axel Hecht <ax...@mozilla.com

> <mailto:ax...@mozilla.com>> wrote:
> >>
> >>> The engine is in a-c,
> >>>
> >>>
> https://github.com/mozilla-mobile/android-components/blob/master/components/browser/search/src/main/assets/searchplugins/diec2.xml

> <https://github.com/mozilla-mobile/android-components/blob/master/components/browser/search/src/main/assets/searchplugins/diec2.xml>

> >>> .
> >>>
> >>> Maybe a redirect on the site broke? As it's using the `mdlc`
> host (note
> >>> the leading `m`).
> >>>
> >>> Axel
> >>>
> >>> Am 02.08.20 um 12:57 schrieb Francesco Lodolo:
> >>>> Sorry, completely missed the Android part (also because I didn't
> >>>> realize we had them customized per locale).
> >>>>
> >>>> Leaving this to Delphine, because I don't know anything about
> >>>> searchplugins on Fenix. I wonder if they mirrored an old
> version of
> >>>> what Firefox was using, in which case Catalan might not be
> the only
> >>>> one with issues.
> >>>>
> >>>> Francesco
> >>>>
> >>>> Il giorno dom 2 ago 2020 alle ore 12:54 Jordi Serratosa

> >>>> <jordis...@gmail.com <mailto:jordis...@gmail.com>> ha

> scritto:
> >>>>> Hi Francesco,
> >>>>> I was referring to Android, not sure if you picked that.
> Just tested in
> >>>>> Nightly 200801 06:06 (Build #22140616)
> >>>>>
> >>>>> Are search engines shared between desktop and mobile versions?
> >>>>>
> >>>>>
> >>>>> salut,
> >>>>> jordi s
> >>>>>
> >>>>> El dg., 2 d’ag. 2020, 6:49, Francesco Lodolo

> <fl...@lodolo.net <mailto:fl...@lodolo.net>> va

> >>> escriure:
> >>>>>> Hi Jordi,
> >>>>>>
> >>>>>> To update existing search engines we need a bug filed in
> >>> Firefox::Search.
> >>>>>> Having said that, I checked the URL and it seems already
> correct to
> >>> me.
> >>>
> https://searchfox.org/mozilla-central/source/browser/components/search/extensions/diec2/manifest.json#22
> <https://searchfox.org/mozilla-central/source/browser/components/search/extensions/diec2/manifest.json#22>
> >>>>>> It tried installing locally that search engines, and
> creating a new
> >>>>>> profile with a Catalan nightly, and it works correctly in
> both cases.
> >>>>>>
> >>>>>> Which version of Firefox are you using? In about:support, which
> >>>>>> version of DIEC2 do you see listed?
> >>>>>>
> >>>>>> Francesco
> >>>>>>
> >>>>>> Il giorno sab 1 ago 2020 alle ore 21:59 Jordi Serratosa

> >>>>>> <jordis...@gmail.com <mailto:jordis...@gmail.com>> ha

> scritto:
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> One of the Catalan search engines changed URL and needs to be
> >>> modified.
> >>>>>>> Tested in Android Firefox 79.1.0-beta.1 (Build
> #2015753459) and
> >>> Nightly.
> >>>>>>> The search engine is DIEC2.
> >>>>>>> Wrong URL:
> >>> https://dlc.iec.cat/?txtEntrada=|{searchTerms}|&operEntrada=0

> <https://dlc.iec.cat/?txtEntrada=%7C%7BsearchTerms%7D%7C&operEntrada=0>

> >>>>>>> Correct URL:
> >>>>>>>
> >>>
> https://dlc.iec.cat/results.asp?txtEntrada=|{searchTerms}|&OperEntrada=0

> <https://dlc.iec.cat/results.asp?txtEntrada=%7C%7BsearchTerms%7D%7C&OperEntrada=0>

> >>>>>>> Could somebody point me in the direction to address that?
> >>>>>>>
> >>>>>>> Thank you!
> >>>>>>>
> >>>>>>> salut,
> >>>>>>> jordi s
> >>>>>>>
> >>>>>>> |
> >>>>>>> |
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> dev-l10n mailing list

> >>>>>>> dev-...@lists.mozilla.org <mailto:dev-...@lists.mozilla.org>
> >>>>>>> https://lists.mozilla.org/listinfo/dev-l10n
> <https://lists.mozilla.org/listinfo/dev-l10n>
> >>> _______________________________________________
> >>> dev-l10n mailing list
> >>> dev-...@lists.mozilla.org <mailto:dev-...@lists.mozilla.org>
> >>> https://lists.mozilla.org/listinfo/dev-l10n
> <https://lists.mozilla.org/listinfo/dev-l10n>
> >>>
> >>
> >> --
> >> Delphine
> >>
> >
> _______________________________________________
> dev-l10n mailing list
> dev-...@lists.mozilla.org <mailto:dev-...@lists.mozilla.org>
> https://lists.mozilla.org/listinfo/dev-l10n
> <https://lists.mozilla.org/listinfo/dev-l10n>
>
>
>
> --
> Delphine

[Delphine L]

No, it's great that you went ahead and did that. I was going to end up
doing it anyways if there still wasn't traction this week (but, "things"
happened... so it may take a few days before folks take on back their
normal activity).

In any case, thanks Jordi! I will make sure that this gets taken care of.

On Thu, Aug 13, 2020 at 5:36 AM Jordi Serratosa <jordis...@gmail.com>
wrote:

> Thank you, Delphine. I created a pull request that should fix the engine.
> I'm not sure whether that's the right way to go.
>
> salut,
> jordi s
>
> El 10/08/2020 a les 19:06, Delphine L ha escrit:
>
> Hi Jordi,
>
> This is the issue:
> https://github.com/mozilla-mobile/android-components/issues/7963

> It's on the mobile team's radar, but hasn't received any traction yet.
>
> I'll follow-up soon if I still don't see any progress.
>
> thanks!
>
> On Sun, Aug 9, 2020 at 6:40 AM Jordi Serratosa <jordis...@gmail.com>

> wrote:
>
>> Hi Delhpine, can you share the bug? I'm not sure whether more action is
>> needed on my part yo address this issue for Catalan.
>>
>> salut,
>> jordi s
>>
>>
>> El 04/08/2020 a les 0:28, Delphine L ha escrit:
>> > Quick update: I've filed an issue in the a-c repository for this, so
>> > hopefully this will be resolved soon :)
>> > cheers
>> >
>> > On Mon, Aug 3, 2020 at 8:47 AM Delphine L <lebedel....@gmail.com>

>> > wrote:
>> >
>> >> Thanks for surfacing all this, I'll follow-up with the mobile team and
>> >> follow-up here.
>> >>
>> >> cheers
>> >>

>> >> --
>> >> Delphine

>> >>
>> >
>> _______________________________________________
>> dev-l10n mailing list
>> dev-...@lists.mozilla.org
>> https://lists.mozilla.org/listinfo/dev-l10n
>>
>
>

> --
> Delphine
>
>

--
Delphine

[Jordi Serratosa]

Yes, I heard the "things" :-/
I understand activity might get slower than usual.
Thank you, Delphine!

salut,
jordi s

>> <lebedel....@gmail.com <mailto:lebedel....@gmail.com>>

>> > wrote:
>> >
>> >> Thanks for surfacing all this, I'll follow-up with the
>> mobile team and
>> >> follow-up here.
>> >>
>> >> cheers
>> >>
>> >> On Sun, Aug 2, 2020 at 8:15 AM Axel Hecht

>> <ax...@mozilla.com <mailto:ax...@mozilla.com>> wrote:
>> >>
>> >>> The engine is in a-c,
>> >>>
>> >>>
>> https://github.com/mozilla-mobile/android-components/blob/master/components/browser/search/src/main/assets/searchplugins/diec2.xml

>> <https://github.com/mozilla-mobile/android-components/blob/master/components/browser/search/src/main/assets/searchplugins/diec2.xml>

>> >>> .
>> >>>
>> >>> Maybe a redirect on the site broke? As it's using the
>> `mdlc` host (note
>> >>> the leading `m`).
>> >>>
>> >>> Axel
>> >>>
>> >>> Am 02.08.20 um 12:57 schrieb Francesco Lodolo:
>> >>>> Sorry, completely missed the Android part (also because
>> I didn't
>> >>>> realize we had them customized per locale).
>> >>>>
>> >>>> Leaving this to Delphine, because I don't know anything
>> about
>> >>>> searchplugins on Fenix. I wonder if they mirrored an old
>> version of
>> >>>> what Firefox was using, in which case Catalan might not
>> be the only
>> >>>> one with issues.
>> >>>>
>> >>>> Francesco
>> >>>>
>> >>>> Il giorno dom 2 ago 2020 alle ore 12:54 Jordi Serratosa

>> >>>> <jordis...@gmail.com <mailto:jordis...@gmail.com>>

>> ha scritto:
>> >>>>> Hi Francesco,
>> >>>>> I was referring to Android, not sure if you picked
>> that. Just tested in
>> >>>>> Nightly 200801 06:06 (Build #22140616)
>> >>>>>
>> >>>>> Are search engines shared between desktop and mobile
>> versions?
>> >>>>>
>> >>>>>
>> >>>>> salut,
>> >>>>> jordi s
>> >>>>>
>> >>>>> El dg., 2 d’ag. 2020, 6:49, Francesco Lodolo

>> <fl...@lodolo.net <mailto:fl...@lodolo.net>> va

>> >>> escriure:
>> >>>>>> Hi Jordi,
>> >>>>>>
>> >>>>>> To update existing search engines we need a bug filed in
>> >>> Firefox::Search.
>> >>>>>> Having said that, I checked the URL and it seems
>> already correct to
>> >>> me.
>> >>>
>> https://searchfox.org/mozilla-central/source/browser/components/search/extensions/diec2/manifest.json#22
>> <https://searchfox.org/mozilla-central/source/browser/components/search/extensions/diec2/manifest.json#22>
>> >>>>>> It tried installing locally that search engines, and
>> creating a new
>> >>>>>> profile with a Catalan nightly, and it works correctly
>> in both cases.
>> >>>>>>
>> >>>>>> Which version of Firefox are you using? In
>> about:support, which
>> >>>>>> version of DIEC2 do you see listed?
>> >>>>>>
>> >>>>>> Francesco
>> >>>>>>
>> >>>>>> Il giorno sab 1 ago 2020 alle ore 21:59 Jordi Serratosa
>> >>>>>> <jordis...@gmail.com

>> <mailto:jordis...@gmail.com>> ha scritto:

>> >>>>>>> Hi,
>> >>>>>>>
>> >>>>>>> One of the Catalan search engines changed URL and
>> needs to be
>> >>> modified.
>> >>>>>>> Tested in Android Firefox 79.1.0-beta.1 (Build
>> #2015753459) and
>> >>> Nightly.
>> >>>>>>> The search engine is DIEC2.
>> >>>>>>> Wrong URL:
>> >>>
>> https://dlc.iec.cat/?txtEntrada=|{searchTerms}|&operEntrada=0

>> <https://dlc.iec.cat/?txtEntrada=%7C%7BsearchTerms%7D%7C&operEntrada=0>

>> >>>>>>> Correct URL:
>> >>>>>>>
>> >>>
>> https://dlc.iec.cat/results.asp?txtEntrada=|{searchTerms}|&OperEntrada=0

>> <https://dlc.iec.cat/results.asp?txtEntrada=%7C%7BsearchTerms%7D%7C&OperEntrada=0>

>> >>>>>>> Could somebody point me in the direction to address that?
>> >>>>>>>
>> >>>>>>> Thank you!
>> >>>>>>>
>> >>>>>>> salut,
>> >>>>>>> jordi s
>> >>>>>>>
>> >>>>>>> |
>> >>>>>>> |
>> >>>>>>>
>> >>>>>>> _______________________________________________
>> >>>>>>> dev-l10n mailing list
>> >>>>>>> dev-...@lists.mozilla.org

>> <mailto:dev-...@lists.mozilla.org>
>> >>>>>>> https://lists.mozilla.org/listinfo/dev-l10n
>> <https://lists.mozilla.org/listinfo/dev-l10n>

>> >>> _______________________________________________
>> >>> dev-l10n mailing list
>> >>> dev-...@lists.mozilla.org

>> <mailto:dev-...@lists.mozilla.org>
>> >>> https://lists.mozilla.org/listinfo/dev-l10n
>> <https://lists.mozilla.org/listinfo/dev-l10n>
>> >>>
>> >>
>> >> --
>> >> Delphine
>> >>
>> >

>> _______________________________________________
>> dev-l10n mailing list
>> dev-...@lists.mozilla.org <mailto:dev-...@lists.mozilla.org>
>> https://lists.mozilla.org/listinfo/dev-l10n