Nonsense sentence in dom.properties

Aki Laaksovirta

unread,

Jul 8, 2011, 5:44:36 AM7/8/11

to dev-...@lists.mozilla.org

In the bottom of dom/chrome/dom/dom.properties, there is a sentence that
just doesn't make sense to me:

"EnablePrivilegeWarning=Use of enablePrivilege is deprecated. Please
use code that runs with the system principal (e.g. an extension) instead."

What does it mean?

--
Aki

flod

unread,

Jul 8, 2011, 5:47:21 AM7/8/11

to dev-...@lists.mozilla.org

Il 08/07/11 11.44, Aki Laaksovirta ha scritto:

https://bugzilla.mozilla.org/show_bug.cgi?id=668030
"Please use code that runs with the same privileges as the application
itself (e.g. an extension) instead"

Francesco

Justin Wood (Callek)

unread,

Jul 8, 2011, 11:41:48 PM7/8/11

to dev-...@lists.mozilla.org, flod, bzba...@mit.edu

Just to be clear, in my understanding of when that is used, we should
have the entity contain both
"Use of enablePrivilege is deprecated."
localized (with enablePrivilege not translated as it is a javascript
literal. and

"Please use code that runs with the same privileges as the application
itself (e.g. an extension) instead"

Could even possibly be s/the application itself/&brandShortName;/
assuming that brandShortName is in scope there.

--
~Justin Wood (Callek)

Justin Wood (Callek)

unread,

Jul 8, 2011, 11:41:48 PM7/8/11

to dev-...@lists.mozilla.org, bzba...@mit.edu, flod

On 7/8/2011 5:47 AM, flod wrote:

Just to be clear, in my understanding of when that is used, we should
have the entity contain both
"Use of enablePrivilege is deprecated."
localized (with enablePrivilege not translated as it is a javascript
literal. and

"Please use code that runs with the same privileges as the application
itself (e.g. an extension) instead"

Could even possibly be s/the application itself/&brandShortName;/

Boris Zbarsky

unread,

Jul 8, 2011, 11:57:07 PM7/8/11

to Justin Wood (Callek), dev-...@lists.mozilla.org, flod

On 7/8/11 11:41 PM, Justin Wood (Callek) wrote:
> On 7/8/2011 5:47 AM, flod wrote:
>> Il 08/07/11 11.44, Aki Laaksovirta ha scritto:

>>> "EnablePrivilegeWarning=Use of enablePrivilege is deprecated. Please
>>> use code that runs with the system principal (e.g. an extension)
>>> instead."

> Just to be clear, in my understanding of when that is used, we should
> have the entity contain both
> "Use of enablePrivilege is deprecated."
> localized (with enablePrivilege not translated as it is a javascript
> literal.

Right. The key part is that the function called "enablePrivilege" is
now deprecated and will soon be removed. People need to stop using it.

> "Please use code that runs with the same privileges as the application
> itself (e.g. an extension) instead"

This is advice for what people can replace their use of enablePrivilege
with.

> Could even possibly be s/the application itself/&brandShortName;/
> assuming that brandShortName is in scope there.

I don't believe it is. But yes, in general.

-Boris

flod

unread,

Jul 9, 2011, 12:56:45 AM7/9/11

to dev-...@lists.mozilla.org, Justin Wood (Callek)

Il 09/07/11 05.41, Justin Wood (Callek) ha scritto:

> Just to be clear, in my understanding of when that is used, we should
> have the entity contain both
> "Use of enablePrivilege is deprecated."

Sorry if my answer could have been misleading, but I was giving an
alternative string only for the part "Please use code that runs with the
system principal (e.g. an extension) instead." since the first part is
clear ;-)

Francesco