Hi,
2012.02.17 14:08, Axel Hecht rašė:
> On 17.02.12 11:48, Michael Bauer wrote:
>> Would it not make sense to assume a signoff at the deadline date if
>> the locale is green at that point? Maybe add a "do not release"
>> button or something for the odd occasion when a locale is green but
>> does not want a release (not that I can think of one)?
>>
>> Quite a few other projects seem to run along those lines.
I would want that too.
> I'm afraid you're more optimistic about the value of those tests than
> I am.
>
> We're constantly trying to make those tests better and cover more
> ground. You can tell by the number of updates I released to
> compare-locales just recently. You can also tell from that number
> that there has been ways to break localizations that we had yet to
> discover.
>
> Also, the source-based checks only cover the most simplistic error
> cases.
>
> The real criteria if we should ship a particular revision is the
> human testing. "Sign-off" means that the localizer is confident that
> the state of the tree is good. Not that you happen to close a window
> when you're trying to copy some text from the scratchpad, for
> example. To give a recent example.
This assumption that the localizer will test before signing up... it
simply can't be verified. I would guess that most of the teams who test
before signing off, would do that either way (and Michael's suggestion
does not even affect their workflow). On the other hand, the (small)
teams who don't have time or don't want to bother testing, they can sign
off untested builds anyway. So again, it's an assumption that has no
strong basis (and I've said it before).
Me, for example. I usually sign off as soon as my tree becomes green, if
I don't expect further changes (that is, if we're in a string freeze and
mobile team haven't announced that they don't care about it). And I
definately don't test everything I commit. I DO use Firefox daily, and
on the box where I'm localizing it, I have nightly builds of both
Firefox and Thunderbird running, and I do check out at least some of the
new strings (those that are unclear of otherwise interesting to me).
But, if I would happen to introduce that Scratchpad bug you mentioned as
an example, I don't think it's very likely that I would have caught it.
And yet, I would have signed that revision off, if it were green.
Signing off is good for those who do the QA homework. But for those who
don't, it's just a useless nuisance. I almost remember the "You have
checked, right?" message by heart, and yet, I can't say I have checked.
:P And by the way, either I am quite good at not making mistakes, or
compare-locales is quite good at catching them, or the users don't
really care, or there are too few users (I believe that at least the
first is true and the last is not) because I only get like one or two
bugs a year filed for my locale.
Regarding the actual subject of this thread: Axel, your proposal
definately makes sense, I wouldn't even ask if I were you. But what does
a suggested sign-off look like? Is it just the sentence saying "There is
a sourcestamp that technically looks good to sign off on.", or is it
something more?
Regards,
Rimas