Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[late-l10n] Thunderbird 3.1b2 String corrections

0 views
Skip to first unread message

Mark Banner

unread,
Apr 22, 2010, 1:18:30 PM4/22/10
to
Hi All,

Following landing of a couple of previous patches, we've just found and
corrected two issues:

Bug 561000 - New migration assistant has a hard coded "Disk space" header

This is on the second page of the migration assistant which can be
access from the Help -> Migration Assistant menu option. The hard coded
string is no-longer hard coded.

string added: featureConfigurator.autoSync.heading in
chrome/messenger/featureConfigurator.dtd


Bug 561059 - Incorrect Encoding of cmd/command symbol in global search
and quick filter search bars

This affects Mac only. The encoding of a symbol was incorrect and
displaying the wrong symbol. You can see this on Mac in the new quick
search bar and the global search bar from Andrew's patch that landed
earlier.

Removed strings:
searchAllMessages.keyLabel.mac (chrome/messenger/messenger.dtd)
quickFilterBar.textbox.emptyText.keyLabel.mac
(chrome/messenger/quickFilterBar.dtd)

Added strings:
searchAllMessages.keyLabel1.mac (chrome/messenger/messenger.dtd)
quickFilterBar.textbox.emptyText.keyLabel1.mac
(chrome/messenger/quickFilterBar.dtd)

Please take care when fixing up the new string's encoding.

Standard8

Rimas Kudelis

unread,
Apr 22, 2010, 3:04:51 PM4/22/10
to
> Bug 561059 - Incorrect Encoding of cmd/command symbol in global search
> and quick filter search bars
>
> This affects Mac only. The encoding of a symbol was incorrect and
> displaying the wrong symbol. You can see this on Mac in the new quick
> search bar and the global search bar from Andrew's patch that landed
> earlier.
>
> Removed strings:
> searchAllMessages.keyLabel.mac (chrome/messenger/messenger.dtd)
> quickFilterBar.textbox.emptyText.keyLabel.mac
> (chrome/messenger/quickFilterBar.dtd)
>
> Added strings:
> searchAllMessages.keyLabel1.mac (chrome/messenger/messenger.dtd)
> quickFilterBar.textbox.emptyText.keyLabel1.mac
> (chrome/messenger/quickFilterBar.dtd)
>
> Please take care when fixing up the new string's encoding.

Just wondering: is it correct that Win/Lin uses Ctrl+K here, and Mac
uses Cmd+F ? Both localization notes actually refer to F and don't hint
at the file/entity to check with.

Regards,
Rimas

Rimas Kudelis

unread,
Apr 22, 2010, 3:22:31 PM4/22/10
to

Another thing: entity quickFilterBar.textbox.emptyText.base in
quickFilterBar.dtd uses three dots instead of a Unicode ellipsis.
Someone may want to fix this.

Rimas

Andrew Sutherland

unread,
Apr 22, 2010, 3:18:31 PM4/22/10
to
On 04/22/2010 12:04 PM, Rimas Kudelis wrote:
> Just wondering: is it correct that Win/Lin uses Ctrl+K here, and Mac
> uses Cmd+F ? Both localization notes actually refer to F and don't hint
> at the file/entity to check with.

Excellent catch! Thank you!

I have resolved this, regrettably revving the entities again:
http://hg.mozilla.org/comm-central/rev/270335f4d429

I have improved the localization notes to explicitly mention the
appropriate entities and the box they are talking about. Those were
cut-and-paste cop-outs and should not have been. Sorry!

Andrew

0 new messages