Missing accesskey, or not?

[Ricardo Palomares Martí­nez]

Hi,

I've been notified of a wrong accesskey in a button. The label key
turned out to be this:

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#62

And there is no correponding accesskey entity. MXR took me to this line:

http://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#699

which, indeed, lacks an accesskey entry for the addonWatchDisable
button. But, if I go to Mercurial in annotation mode, the file looks
the same than MXR:

http://hg.mozilla.org/mozilla-central/annotate/24f4d8e5e24b/browser/components/nsBrowserGlue.js

but the changeset for that part of the file does include the accesskey
line! What am I doing wrong?

TIA

--
Proyecto NAVE (Mozilla es-ES Localization Team)
Mozilla Hispano Community

[YF]

I found the https://hg.mozilla.org/mozilla-central/rev/1e6108d642bf and
https://bugzilla.mozilla.org/show_bug.cgi?id=1153198, through open all of
'diff' links in the file's 'revisions' and 'find in all tabs' (FindBar
Tweak).

2015-08-10 4:05 GMT+08:00 Ricardo Palomares Martí­nez <
rpm....@proyectonave.es>:

> _______________________________________________
> dev-l10n mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-l10n
>



--
Best regards,
YFdyh000.

[Theo Chevalier]

Hi Ricardo,

Good catch, I can confirm the issue in French. Looks like you found the
issue and the appropriated fix as it seems the accesskey line has been
removed by another commit (that's why you can't see it in annotate
mode). You can go ahead and file a bug (please CC me), or I'll file one
on Monday.

Cheers,
Théo

[Theo Chevalier]

Note that the bug should block the bug pointed by YF (Bug 1153198) as it
was supposed to remove the accesskey, but a random character is now
picked up instead.

Cheers,
Théo

[Francesco Lodolo [:flod]]

Il 10/08/15 04:12, Theo Chevalier ha scritto:

> Good catch, I can confirm the issue in French. Looks like you found
> the issue and the appropriated fix as it seems the accesskey line has
> been removed by another commit (that's why you can't see it in
> annotate mode). You can go ahead and file a bug (please CC me), or
> I'll file one on Monday.

I'm not sure I understand the original problem: the report was that the
accesskey is wrong or missing?

Bug 1153198 is exactly about removing the accesskey, so it's not a
regression, it's expected behavior.

Francesco

[Theo Chevalier]

Bug 1153198 removed the possibility to define an acceskey, but in the UI
we still have one ("U"), and it's not a character we have in "Disable".
So what we want now, is removing that.

Théo

[Theo Chevalier]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1192901

Théo