Update CSS linter?

8 views
Skip to first unread message

J. Ryan Stinnett

unread,
Feb 4, 2015, 8:43:48 PM2/4/15
to dev-gaia
What's the right way to update the CSS linter for a property it
doesn't understand, but is accepted by Gecko?

The upstream library doesn't seem to have much activity, and it
doesn't seem like our copy has been touched since it first landed.

I could:

* Patch our copy
* Send a PR to upstream and eventually update ours
* Skip the error in xfail.list

Any suggestions would be great!

- Ryan

Kevin Grandon

unread,
Feb 4, 2015, 9:00:36 PM2/4/15
to J. Ryan Stinnett, dev-gaia
I would prefer to update the upstream repo if possible. If for some reason it's inactive and they don't take our PR, my suggestion would be to fork it to the mozilla-b2g org. If we need a quick workaround, then we could always skip the errors in the meantime.

Best,
Kevin

_______________________________________________
dev-gaia mailing list
dev-...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-gaia

Jan Keromnes

unread,
Feb 5, 2015, 9:59:55 AM2/5/15
to Kevin Grandon, J. Ryan Stinnett, dev-gaia
The CSSLint project does look like it's been abandoned since last August, and issues / pull requests are piling up. I've sent an email to the maintainer, asking for news and/or commit rights. If he doesn't reply soon, I don't mind us forking.

Also, I feel uneasy adding entire new files to xfail.list, but there doesn't seem to be an ignore feature yet (one is being added in the pull requests).

Jan Keromnes

unread,
Feb 5, 2015, 10:53:09 AM2/5/15
to Kevin Grandon, J. Ryan Stinnett, dev-gaia
For CSS linting, we also run the code through a gecko parser to check for errors and warnings, and it appears that we're stuck with b2g34 because of some mac issues.

The particular rule that spawned this discussion is "object-fit: cover", and it seems to require at least b2g36[1], so that's another reason to add to xfail.list, until we fix both steps of the linting process. This makes me sad.

[1] http://caniuse.com/object-fit
Reply all
Reply to author
Forward
0 new messages